Issue 8271003: Shutdown

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8271003: Shutdown (Closed)

Created:
9 years, 2 months ago by oshima

Modified:
8 years, 5 months ago

Reviewers:
achuithb

CC:
chromium-reviews, stevenjb, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Shutdown BUG= TEST=

Patch Set 1 #

Total comments: 1

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+150 lines, -23 lines)			Patch
M	chrome/browser/browser_process_impl.cc	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/browser_shutdown.h	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/browser_shutdown.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/chrome_browser_main_x11.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/login_utils.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/browser_list.h	View	2 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/browser_list.cc	View	13 chunks	+133 lines, -17 lines	1 comment	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

achuithb

9 years, 1 month ago (2011-10-28 22:22:26 UTC) #1

http://codereview.chromium.org/8271003/diff/1/chrome/browser/ui/browser_list.cc
File chrome/browser/ui/browser_list.cc (right):

http://codereview.chromium.org/8271003/diff/1/chrome/browser/ui/browser_list....
chrome/browser/ui/browser_list.cc:517: Browser* browser = *i;
Do you think you could also clean this loop up if possible? It's quite difficult
to read.

Expand Messages | Collapse Messages