Roll skia to r2478

Roll skia to r2478.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105526

[bsalomon, 2011-10-14 12:41:32]

PTAL. (OWNERS reviews needed for trivial path-to-header changes in ui/gfx/gl and
webkit/glue)

[epoger, 2011-10-14 13:58:45]

The trybot failures I see look typical (not made any worse by this CL)

[epoger, 2011-10-14 14:02:13]

On 2011/10/14 13:58:45, epoger wrote:
> The trybot failures I see look typical (not made any worse by this CL)

Actually... about the video-playing-and-pause failures in linux_layout and
linux_layout_rel trybots... I'm surprised that they made the trybots red, given
that you added them to test_expectations.  Do you understand why they fail in
spite of that?

[bsalomon, 2011-10-14 14:20:39]

On 2011/10/14 14:02:13, epoger wrote:
> On 2011/10/14 13:58:45, epoger wrote:
> > The trybot failures I see look typical (not made any worse by this CL)
> 
> Actually... about the video-playing-and-pause failures in linux_layout and
> linux_layout_rel trybots... I'm surprised that they made the trybots red,
given
> that you added them to test_expectations.  Do you understand why they fail in
> spite of that?

My understanding is that try bots don't look at the downstream
test_expectations.txt, just the WebKit test_expectations.txt. The build bots
look at both.

[epoger, 2011-10-14 14:36:17]

On 2011/10/14 14:20:39, bsalomon wrote:
> On 2011/10/14 14:02:13, epoger wrote:
> > On 2011/10/14 13:58:45, epoger wrote:
> > > The trybot failures I see look typical (not made any worse by this CL)
> > 
> > Actually... about the video-playing-and-pause failures in linux_layout and
> > linux_layout_rel trybots... I'm surprised that they made the trybots red,
> given
> > that you added them to test_expectations.  Do you understand why they fail
in
> > spite of that?
> 
> My understanding is that try bots don't look at the downstream
> test_expectations.txt, just the WebKit test_expectations.txt. The build bots
> look at both.

Aha. LGTM.

[Ken Russell (switch to Gerrit), 2011-10-14 16:41:52]

OWNERS for ui/gfx/gl/ LGTM

[tony, 2011-10-14 18:02:02]

webkit/glue LGTM