Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3289)

Unified Diff: chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.cc

Issue 8268003: Hide autocomplete popup when IME candidate window is open (on Windows). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: initialize Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.cc
diff --git a/chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.cc b/chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.cc
index 07b3786722501071bcf90eebad430ffe4601a675..df2c996c64996104a7f57a91f408a80125bbb1a2 100644
--- a/chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.cc
+++ b/chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.cc
@@ -293,6 +293,12 @@ void AutocompletePopupContentsView::UpdatePopupAppearance() {
return;
}
+ if (omnibox_view_->ShouldHideAutocompletePopup()) {
+ if (popup_)
+ popup_->Hide();
+ return;
+ }
+
// Update the match cached by each row, in the process of doing so make sure
// we have enough row views.
size_t child_rv_count = child_count();
@@ -355,6 +361,7 @@ void AutocompletePopupContentsView::UpdatePopupAppearance() {
}
popup_->Show();
} else {
+ popup_->Show();
// Animate the popup shrinking, but don't animate growing larger since that
// would make the popup feel less responsive.
start_bounds_ = GetWidget()->GetWindowScreenBounds();

Powered by Google App Engine
This is Rietveld 408576698