Faster slow asserts.

src/checks.h

Index: src/checks.h
===================================================================
--- src/checks.h	(revision 9605)
+++ src/checks.h	(working copy)
@@ -257,12 +257,9 @@
     SEMI_STATIC_JOIN(__StaticAssertTypedef__, __LINE__)
 
 
-namespace v8 { namespace internal {
+extern bool FLAG_enable_slow_asserts;
 
-bool EnableSlowAsserts();
 
-} }  // namespace v8::internal
-
 // The ASSERT macro is equivalent to CHECK except that it only
 // generates code in debug builds.
 #ifdef DEBUG
@@ -273,7 +270,7 @@
 #define ASSERT_GE(v1, v2)    CHECK_GE(v1, v2)
 #define ASSERT_LT(v1, v2)    CHECK_LT(v1, v2)
 #define ASSERT_LE(v1, v2)    CHECK_LE(v1, v2)
-#define SLOW_ASSERT(condition) if (EnableSlowAsserts()) CHECK(condition)
+#define SLOW_ASSERT(condition) if (FLAG_enable_slow_asserts) CHECK(condition)

[Sven Panne, 2011/10/13 13:07:00]

Although it's a bit late for a comment: Using the ugly, but common "do { if ...
} while(0)" idiom here would be safer...

[Kevin Millikin (Chromium), 2011/10/13 13:21:19]

Yes, we need that, or else the ugly

if (FLAG_enable_slow_asserts) CHECK(condition) else (void)0

as used in the CHECK_OK macro in parser.h.

 #else
 #define ASSERT_RESULT(expr)     (expr)
 #define ASSERT(condition)      ((void) 0)