chrome/chrome_browser.gypi - Issue 8265005: first run bubble using the views/bubble api.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser.gypi

Issue 8265005: first run bubble using the views/bubble api. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: fix defines. Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/chrome_browser.gypi

diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi

index 0f2bff43effe1338d54e76c5c27830e688067ec7..dc5762bf552fdc70d3523fc2b0ae70c3813eb60f 100644

--- a/chrome/chrome_browser.gypi

+++ b/chrome/chrome_browser.gypi

@@ -4147,7 +4147,6 @@

['exclude', '^browser/ui/views/dropdown_bar_host_win.cc'],

['exclude', '^browser/ui/views/external_protocol_dialog.cc'],

['exclude', '^browser/ui/views/find_bar_host_win.cc'],

- ['exclude', '^browser/ui/views/first_run_bubble.cc'],

['exclude', '^browser/ui/views/frame/browser_frame_win.cc'],

['exclude', '^browser/ui/views/frame/browser_frame_win.h'],

['exclude', '^browser/ui/views/frame/glass_browser_frame_view.cc'],

@@ -4685,6 +4684,7 @@

['include', '^browser/ui/views/extensions/extension_uninstall_dialog_view.cc'],

['include', '^browser/ui/views/extensions/extension_view.cc'],

['include', '^browser/ui/views/extensions/extension_view.h'],

+ ['include', '^browser/ui/views/first_run_bubble.cc'],

['include', '^browser/ui/views/find_bar_host.cc'],

['include', '^browser/ui/views/find_bar_host.h'],

['include', '^browser/ui/views/find_bar_host_gtk.cc'],

@@ -5071,6 +5071,7 @@

['include', '^browser/ui/views/constrained_window_views.cc'],

['include', '^browser/ui/views/dropdown_bar_host_aura.cc'],

['include', '^browser/ui/views/find_bar_host_aura.cc'],

+ ['include', '^browser/ui/views/first_run_bubble.cc'],

msw 2011/10/20 19:17:50 I don't think this explicit include is required, b

alicet1 2011/10/21 19:13:16 I tried removing it, but the generated make file o

['include', '^browser/ui/views/frame/browser_frame_aura.cc'],

['include', '^browser/ui/views/importer/import_lock_dialog_view.cc'],

['include', '^browser/ui/views/native_constrained_window_aura.cc'],