first run bubble using the views/bubble api.

chrome/browser/ui/views/first_run_bubble_unittest.cc

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/search_engines/template_url.h"
+#include "chrome/browser/search_engines/template_url_service.h"
+#include "chrome/browser/search_engines/template_url_service_factory.h"
+#include "chrome/browser/ui/views/first_run_bubble.h"
+#include "chrome/test/base/testing_profile.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "views/test/views_test_base.h"
+#include "views/view.h"

[msw, 2011/11/12 03:35:55]

including view.h may not be necessary.

[alicet1, 2011/11/15 02:09:50]

Done.

+#include "views/widget/widget.h"
+
+class FirstRunBubbleTest : public views::ViewsTestBase {
+ public:
+  FirstRunBubbleTest();
+  virtual ~FirstRunBubbleTest();
+
+  // Overrides from views::ViewsTestBase:
+  virtual void SetUp() OVERRIDE;
+
+ protected:
+  TestingProfile* profile() { return &profile_; }
+
+ private:
+  TestingProfile profile_;
+  TemplateURL* default_t_url_;
+
+  DISALLOW_COPY_AND_ASSIGN(FirstRunBubbleTest);
+};
+
+FirstRunBubbleTest::FirstRunBubbleTest() : default_t_url_(NULL) {}
+FirstRunBubbleTest::~FirstRunBubbleTest() {}
+
+void FirstRunBubbleTest::SetUp() {
+  ViewsTestBase::SetUp();
+  profile_.CreateTemplateURLService();
+  TemplateURLService* turl_model =
+      TemplateURLServiceFactory::GetForProfile(&profile_);
+  turl_model->Load();
+  // Reset the default TemplateURL.
+  default_t_url_ = new TemplateURL();
+  turl_model->Add(default_t_url_);
+  turl_model->SetDefaultSearchProvider(default_t_url_);

[msw, 2011/11/12 03:35:55]

It seems like you should be able to SetDefaultSearchProvider, and then
GetDefaultSearchEngineName will just return an empty string. Perhaps you don't
even have to SetDefaultSearchProvider at all, and even more of this tangential
code can go away.

[alicet1, 2011/11/15 02:09:50]

ah not quite, you'll need at least one valid template url service. updated the
code to get rid of more.

+}
+
+TEST_F(FirstRunBubbleTest, CreateAndClose) {
+  views::View* anchor = new views::View();
+  FirstRunBubble* delegate =
+      FirstRunBubble::Show(profile(),
+                           anchor,

[msw, 2011/11/12 03:35:55]

You should be able to just send in NULL here and remove the |anchor| local.

[alicet1, 2011/11/15 02:09:50]

Done.

+                           views::BubbleBorder::TOP_LEFT,
+                           FirstRun::MINIMAL_BUBBLE);
+  EXPECT_TRUE(delegate != NULL);
+  delegate->GetWidget()->CloseNow();
+}