first run bubble using the views/bubble api.

chrome/browser/ui/views/first_run_bubble_unittest.cc

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/message_loop.h"
+#include "base/string_util.h"

[msw, 2011/11/03 20:25:38]

I don't think string_util.h is needed.

[alicet1, 2011/11/04 22:37:36]

Done.

+#include "base/utf_string_conversions.h"

[msw, 2011/11/03 20:25:38]

I don't think utf_string_conversions.h is needed.

[alicet1, 2011/11/04 22:37:36]

Done.

+#include "chrome/browser/search_engines/template_url.h"
+#include "chrome/browser/search_engines/template_url_service.h"
+#include "chrome/browser/search_engines/template_url_service_factory.h"
+#include "chrome/browser/ui/views/first_run_bubble.h"
+#include "chrome/test/base/testing_profile.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "views/view.h"

[msw, 2011/11/03 20:25:38]

I don't think view.h is needed.

[alicet1, 2011/11/04 22:37:36]

Done.

+#include "views/widget/widget.h"
+
+#if defined(USE_AURA)
+#include "ui/aura/desktop.h"
+#endif
+
+class FirstRunBubbleTest : public testing::Test {
+ public:
+  void SetUp() {

[msw, 2011/11/03 20:25:38]

SetUp and TearDown are protected virtual method overrides, they should be
defined outside the declaration, kept protected, and marked as OVERRIDESs with
the appropriate comment.

[alicet1, 2011/11/04 22:37:36]

Done.

+    profile_.CreateTemplateURLService();
+    MessageLoopForUI::current()->RunAllPending();
+    TemplateURLService* turl_model =

[msw, 2011/11/03 20:25:38]

Wow is all this really needed for a TestingProfile?
Miranda probably knows the simplest test/mock profile we can use for this test.

[Miranda Callahan, 2011/11/03 20:59:39]

I don't think you have to do all this -- would it make sense to just use a
TestingProfile, and mock in Google for the DefaultSearchProvider?

[alicet1, 2011/11/04 22:37:36]

I tried that route first, and I think it worked out to about the same amount of
code, yeah I need to set the search provider, so that requires a template url
and model somewhere. I can try the mocks again to see if it looks better.

+        TemplateURLServiceFactory::GetForProfile(&profile_);
+    turl_model->Load();
+    // Reset the default TemplateURL.
+    default_t_url_ = new TemplateURL();
+    turl_model->Add(default_t_url_);
+    turl_model->SetDefaultSearchProvider(default_t_url_);
+  }
+
+  MessageLoopForUI message_loop_;

[msw, 2011/11/03 20:25:38]

These data members should be made private.

[alicet1, 2011/11/04 22:37:36]

Done.

+  TestingProfile profile_;
+  TemplateURL* default_t_url_;
+
+  void RunPendingMessages() {

[msw, 2011/11/03 20:25:38]

It seems like this function's body could be put directly in TearDown.

[alicet1, 2011/11/04 22:37:36]

Done.

+#if defined(USE_AURA)

[msw, 2011/11/03 20:25:38]

Hopefully Ben or someone more familiar with aura testing can comment on this,
but it seems to do the right thing.

[alicet1, 2011/11/04 22:37:36]

yeah, this is from views_test_base.h, on how aura desktop should do the message
dispatching. I've made this a subclass of that instead, that is how the views
unittests can get the message loop working properly for aura.

the downside is I'll drag in the views_test_base/delegate into unit_tests,
whenever views lib is included in the setting.

+    message_loop_.RunAllPendingWithDispatcher(
+        aura::Desktop::GetInstance()->GetDispatcher());
+#else
+    message_loop_.RunAllPending();
+#endif
+  }
+
+  void TearDown() {
+    RunPendingMessages();
+  }
+};
+
+TEST_F(FirstRunBubbleTest, CreateAndClose) {
+  gfx::Rect anchor(10, 20, 0, 0);
+  FirstRunBubble* delegate =
+      FirstRunBubble::Show(&profile_,
+                           NULL,
+                           anchor,
+                           views::BubbleBorder::TOP_LEFT);
+  EXPECT_TRUE(delegate != NULL);
+  delegate->GetWidget()->CloseNow();
+}