Issue 8264001: ntp4: apps apps apps...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8264001: ntp4: apps apps apps... (Closed)

Created:
9 years, 2 months ago by Evan Stade

Modified:
9 years, 2 months ago

Reviewers:
csilv, commit-bot: I haz the power, Dan Beam

CC:
chromium-reviews, estade+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

ntp4: apps apps apps... Set the default pane name for apps panes to Apps (rather than blank). Also, fix a bug where app pane renames didn't get propagated across open NTPs. BUG=97821 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105524

Patch Set 1 #

Total comments: 1

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -9 lines)			Patch
	M	chrome/browser/resources/ntp4/new_tab.js	View		6 chunks	+8 lines, -8 lines	1 comment	Download
	M	chrome/browser/ui/webui/ntp/app_launcher_handler.cc	View		2 chunks	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Dan Beam

lgtm + comment http://codereview.chromium.org/8264001/diff/1/chrome/browser/resources/ntp4/new_tab.js File chrome/browser/resources/ntp4/new_tab.js (right): http://codereview.chromium.org/8264001/diff/1/chrome/browser/resources/ntp4/new_tab.js#newcode571 chrome/browser/resources/ntp4/new_tab.js:571: saveAppPageName(tempPage, localStrings.getString('appDefaultPageName')); Might it make sense ...

9 years, 2 months ago (2011-10-14 08:19:56 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/8264001/1

9 years, 2 months ago (2011-10-14 16:43:59 UTC) #4

Change committed as 105524

Expand Messages | Collapse Messages