Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 8263003: cros: PowerLibrary virtual functions should be named using CamelCase. (Closed)

Created:
9 years, 2 months ago by tfarina
Modified:
9 years, 2 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, stevenjb, kkania, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

cros: PowerLibrary virtual functions should be named using CamelCase. See http://www.chromium.org/developers/coding-style Inline Functions. R=stevenjb@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105634

Patch Set 1 #

Patch Set 2 : fix mock_power_library.h #

Patch Set 3 : fix browser_tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -77 lines) Patch
M chrome/browser/automation/testing_automation_provider_chromeos.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/cros/cros_mock.cc View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/cros/mock_power_library.h View 1 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/cros/power_library.h View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/cros/power_library.cc View 2 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/chromeos/low_battery_observer.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/status/power_menu_button.cc View 1 chunk +10 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/status/power_menu_button_browsertest.cc View 1 2 3 chunks +24 lines, -24 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tfarina
9 years, 2 months ago (2011-10-13 02:56:59 UTC) #1
stevenjb
9 years, 2 months ago (2011-10-13 21:57:31 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698