Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1271)

Issue 8262011: Use rewritten url of a tab to find the zoom level from zoom map. Zoom map is (Closed)

Created:
9 years, 2 months ago by wrm364
Modified:
9 years, 2 months ago
CC:
chromium-reviews, creis+watch_chromium.org, dpranke+watch-content_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, ajwong+watch_chromium.org
Visibility:
Public.

Description

Use rewritten url of a tab to find the zoom level from zoom map. Zoom map is maintained using rewritten URLs. Using GetURL() to find the zoom level will fail in case of rewritten URLs as GetURL() returns virtual_url which will be different from the rewritten URL. Contributed by wrm364@motorola.com BUG=94408 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105474

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/tab_contents/tab_contents.cc View 1 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
wrm364
This patch is same as http://codereview.chromium.org/8245003/, but this patch has been pushed with a different ...
9 years, 2 months ago (2011-10-13 10:31:07 UTC) #1
jam
lgtm
9 years, 2 months ago (2011-10-13 16:35:30 UTC) #2
csilv
lgtm
9 years, 2 months ago (2011-10-13 18:08:54 UTC) #3
wrm364
On 2011/10/13 18:08:54, csilv wrote: > lgtm Avi and brettw: Can you please check the ...
9 years, 2 months ago (2011-10-14 06:33:32 UTC) #4
Avi (use Gerrit)
Did Motorola a corporate CLA? I'm not connected up to the VPN so I can't ...
9 years, 2 months ago (2011-10-14 06:41:20 UTC) #5
wrm364
On 2011/10/14 06:41:20, Avi wrote: > Did Motorola a corporate CLA? I'm not connected up ...
9 years, 2 months ago (2011-10-14 06:51:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wrm364@motorola.com/8262011/1
9 years, 2 months ago (2011-10-14 06:55:07 UTC) #7
commit-bot: I haz the power
Can't apply patch for file AUTHORS. While running patch -p0 --forward --force; patching file AUTHORS ...
9 years, 2 months ago (2011-10-14 06:55:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wrm364@motorola.com/8262011/8001
9 years, 2 months ago (2011-10-14 07:01:27 UTC) #9
commit-bot: I haz the power
9 years, 2 months ago (2011-10-14 09:11:20 UTC) #10
Change committed as 105474

Powered by Google App Engine
This is Rietveld 408576698