Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: test/mjsunit/elements-kind.js

Issue 8261007: Fixing test failures in arm and x64 due to missing implementation introduced in r9605. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/elements-kind.js
diff --git a/test/mjsunit/elements-kind.js b/test/mjsunit/elements-kind.js
index 0ae2e692f430dfad1697b05a1665a9c52f41a559..36a0582ebb7c7139953addb5029f17fe7120d44c 100644
--- a/test/mjsunit/elements-kind.js
+++ b/test/mjsunit/elements-kind.js
@@ -177,11 +177,19 @@ for (var i = 0; i < 3; i++) {
for (var i = 0; i < 3; i++) {
polymorphic(strings, elements_kind.fast);
}
+/* In the first iteration, feeding polymorphic with a fast double elements
+ * array leads to a miss and is then routed to runtime code. No conversion
+ * is done in there. The second time the store is handled by the newly
+ * created IC, which converts the fast double elements into fast elements
+ * since arrays with fast elements has been handled earlier in polymorphic.
Jakob Kummerow 2011/10/13 12:01:17 s/has/have/, and for readability s/polymorphic/pol
+ * Since the x64 and arm port of the generated code conversion does not yet
+ * exist, this test is skipped for now.
for (var i = 0; i < 3; i++) {
polymorphic(doubles, i == 0 && support_smi_only_arrays
? elements_kind.fast_double
: elements_kind.fast);
}
+*/
/* Element transitions have not been implemented in crankshaft yet.
%OptimizeFunctionOnNextCall(polymorphic);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698