Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Side by Side Diff: test/mjsunit/elements-kind.js

Issue 8261007: Fixing test failures in arm and x64 due to missing implementation introduced in r9605. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 159 matching lines...) Expand 10 before | Expand all | Expand 10 after
170 assertKind(support_smi_only_arrays 170 assertKind(support_smi_only_arrays
171 ? elements_kind.fast_double 171 ? elements_kind.fast_double
172 : elements_kind.fast, 172 : elements_kind.fast,
173 doubles); 173 doubles);
174 for (var i = 0; i < 3; i++) { 174 for (var i = 0; i < 3; i++) {
175 polymorphic(smis, elements_kind.fast_smi_only); 175 polymorphic(smis, elements_kind.fast_smi_only);
176 } 176 }
177 for (var i = 0; i < 3; i++) { 177 for (var i = 0; i < 3; i++) {
178 polymorphic(strings, elements_kind.fast); 178 polymorphic(strings, elements_kind.fast);
179 } 179 }
180 /* In the first iteration, feeding polymorphic with a fast double elements
181 * array leads to a miss and is then routed to runtime code. No conversion
182 * is done in there. The second time the store is handled by the newly
183 * created IC, which converts the fast double elements into fast elements
184 * since arrays with fast elements has been handled earlier in polymorphic.
Jakob Kummerow 2011/10/13 12:01:17 s/has/have/, and for readability s/polymorphic/pol
185 * Since the x64 and arm port of the generated code conversion does not yet
186 * exist, this test is skipped for now.
180 for (var i = 0; i < 3; i++) { 187 for (var i = 0; i < 3; i++) {
181 polymorphic(doubles, i == 0 && support_smi_only_arrays 188 polymorphic(doubles, i == 0 && support_smi_only_arrays
182 ? elements_kind.fast_double 189 ? elements_kind.fast_double
183 : elements_kind.fast); 190 : elements_kind.fast);
184 } 191 }
192 */
185 193
186 /* Element transitions have not been implemented in crankshaft yet. 194 /* Element transitions have not been implemented in crankshaft yet.
187 %OptimizeFunctionOnNextCall(polymorphic); 195 %OptimizeFunctionOnNextCall(polymorphic);
188 polymorphic(smis, elements_kind.fast_smi_only); 196 polymorphic(smis, elements_kind.fast_smi_only);
189 polymorphic(strings, elements_kind.fast); 197 polymorphic(strings, elements_kind.fast);
190 polymorphic(doubles, elements_kind.fast); 198 polymorphic(doubles, elements_kind.fast);
191 199
192 // Crankshaft support for smi-only elements in dynamic array literals. 200 // Crankshaft support for smi-only elements in dynamic array literals.
193 function get(foo) { return foo; } // Used to generate dynamic values. 201 function get(foo) { return foo; } // Used to generate dynamic values.
194 202
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
265 f[0] = 1.5; 273 f[0] = 1.5;
266 assertKind(elements_kind.fast_double, f); 274 assertKind(elements_kind.fast_double, f);
267 assertFalse(%HaveSameMap(e, f)); 275 assertFalse(%HaveSameMap(e, f));
268 f[0] = "bar"; 276 f[0] = "bar";
269 assertKind(elements_kind.fast, f); 277 assertKind(elements_kind.fast, f);
270 assertTrue(%HaveSameMap(e, f)); 278 assertTrue(%HaveSameMap(e, f));
271 } 279 }
272 280
273 // Throw away type information in the ICs for next stress run. 281 // Throw away type information in the ICs for next stress run.
274 gc(); 282 gc();
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698