Issue 8261005: More options for the types of margins to add.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8261005: More options for the types of margins to add. (Closed)

Created:
9 years, 2 months ago by vandebo (ex-Chrome)

Modified:
9 years, 2 months ago

Reviewers:
commit-bot: I haz the power

CC:
chromium-reviews, Paweł Hajdan Jr., arv (Not doing code reviews), darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More options for the types of margins to add. Original (broken) CL: http://codereview.chromium.org/8227034 Already approved by dpapad@ TBR=dpapad@chromium.org BUG=NONE TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105281

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+49 lines, -40 lines)			Patch
M	chrome/browser/resources/print_preview/margin_settings.js	View	3 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/resources/print_preview/print_preview.js	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	chrome/renderer/print_web_view_helper.cc	View	1 chunk	+21 lines, -22 lines	0 comments	Download
M	chrome/renderer/print_web_view_helper_browsertest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	printing/print_job_constants.h	View	3 chunks	+10 lines, -2 lines	0 comments	Download
M	printing/print_job_constants.cc	View	2 chunks	+6 lines, -6 lines	0 comments	Download

Total messages: 2 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/8261005/1

9 years, 2 months ago (2011-10-13 07:15:16 UTC) #1

Change committed as 105281