Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Issue 8261001: Add a safeguard because I always use -p 8000 by error when I mean --port 8000. (Closed)

Created:
9 years, 2 months ago by M-A Ruel
Modified:
9 years, 2 months ago
CC:
chromium-reviews, Dirk Pranke, M-A Ruel
Visibility:
Public.

Description

Add a safeguard because I always use -p 8000 by error when I mean --port 8000. R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105226

Patch Set 1 #

Patch Set 2 : Oops, I meant patchlevel, not patchset. #

Patch Set 3 : Sorry about that, this one was actually tested #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M trychange.py View 1 2 1 chunk +5 lines, -0 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
M-A Ruel
9 years, 2 months ago (2011-10-13 00:41:34 UTC) #1
Dirk Pranke
lgtm. http://codereview.chromium.org/8261001/diff/3001/trychange.py File trychange.py (right): http://codereview.chromium.org/8261001/diff/3001/trychange.py#newcode662 trychange.py:662: 'Have you tried --port instead? You probably confused ...
9 years, 2 months ago (2011-10-13 00:46:33 UTC) #2
M-A Ruel
http://codereview.chromium.org/8261001/diff/3001/trychange.py File trychange.py (right): http://codereview.chromium.org/8261001/diff/3001/trychange.py#newcode662 trychange.py:662: 'Have you tried --port instead? You probably confused -p ...
9 years, 2 months ago (2011-10-13 00:47:32 UTC) #3
Dirk Pranke
Ah. Right then. On Wed, Oct 12, 2011 at 5:47 PM, <maruel@chromium.org> wrote: > > ...
9 years, 2 months ago (2011-10-13 00:48:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/8261001/3001
9 years, 2 months ago (2011-10-13 00:51:48 UTC) #5
commit-bot: I haz the power
9 years, 2 months ago (2011-10-13 00:58:09 UTC) #6
Change committed as 105226

Powered by Google App Engine
This is Rietveld 408576698