Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Unified Diff: chrome/browser/policy/configuration_policy_reader_unittest.cc

Issue 8258018: Generate Chrome policy definition list from policy_templates.json. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix the unittest fix Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/policy/configuration_policy_reader_unittest.cc
diff --git a/chrome/browser/policy/configuration_policy_reader_unittest.cc b/chrome/browser/policy/configuration_policy_reader_unittest.cc
index dc76a921129745684d3a124419fb6ee746ff8f2a..670c0b526f9684457eaddb673ea2c844e8594694 100644
--- a/chrome/browser/policy/configuration_policy_reader_unittest.cc
+++ b/chrome/browser/policy/configuration_policy_reader_unittest.cc
@@ -148,9 +148,6 @@ TEST_F(ConfigurationPolicyReaderTest, SetIntegerValue) {
class PolicyStatusTest : public testing::Test {
protected:
- typedef ConfigurationPolicyProvider::PolicyDefinitionList
- PolicyDefinitionList;
-
PolicyStatusTest() {
managed_platform_ = new MockConfigurationPolicyReader();
managed_cloud_ = new MockConfigurationPolicyReader();
@@ -163,8 +160,7 @@ class PolicyStatusTest : public testing::Test {
recommended_cloud_));
status_ok_ = ASCIIToUTF16("ok");
- policy_list_ =
- ConfigurationPolicyPrefStore::GetChromePolicyDefinitionList();
+ policy_list_ = GetChromePolicyDefinitionList();
policy_list_size_ =
static_cast<size_t>(policy_list_->end - policy_list_->begin);
}
@@ -347,12 +343,4 @@ TEST_F(PolicyStatusTest, GetPolicyStatusListSetPolicies) {
}
}
-TEST_F(PolicyStatusTest, GetPolicyName) {
- for (const PolicyDefinitionList::Entry* entry = policy_list_->begin;
- entry != policy_list_->end; ++entry) {
- EXPECT_EQ(ASCIIToUTF16(entry->name),
- PolicyStatus::GetPolicyName(entry->policy_type));
- }
-}
-
} // namespace policy
« no previous file with comments | « chrome/browser/policy/configuration_policy_reader.cc ('k') | chrome/browser/policy/file_based_policy_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698