Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 8258017: Changes the Emacs lisp mode to use the dart-mode-map instead of the c-mode-map. Currently, there ... (Closed)

Created:
9 years, 2 months ago by Ola.Bini
Modified:
9 years, 2 months ago
Reviewers:
vsm, kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Changes the Emacs lisp mode to use the dart-mode-map instead of the c-mode-map. Currently, there are no key bindings specific for Dart, but in order to add extensions that are only active for Dart, it would be useful to have the correct Dart keymap used.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/utils/elisp/dart-mode.el View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Ola.Bini
9 years, 2 months ago (2011-10-13 11:45:21 UTC) #1
kasperl
Adding vsm as a reviewer.
9 years, 2 months ago (2011-10-14 09:49:26 UTC) #2
vsm
Looks good to me.
9 years, 2 months ago (2011-10-16 22:52:43 UTC) #3
kasperl
9 years, 2 months ago (2011-10-17 13:55:41 UTC) #4
Committed: https://code.google.com/p/dart/source/detail?r=467. Thank you for
your contribution, Ola!

Powered by Google App Engine
This is Rietveld 408576698