Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 8258012: Fix a number of bugs with inlining calls as function. (Closed)

Created:
9 years, 2 months ago by fschneider
Modified:
9 years, 2 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix a number of bugs with inlining calls as function. 1. Record AST id for CallFunctionStub. 2. Correctly extract cached target from CallFunctionStub inline cache. 3. Fix a bug when inling call as a function in effect or value context: Handle abnormal exits correcty. 4. Fix a bug when inlining call as a function in test context: drop function correctly from true and false block. 5. Avoid inlining mutually recursive functions by checking the stack of function states before inlining. This was not a bug, but is just a more general check to avoid recursive inlining. Committed: http://code.google.com/p/v8/source/detail?r=9619

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -57 lines) Patch
M src/hydrogen.cc View 1 4 chunks +18 lines, -8 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/type-info.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/type-info.cc View 1 2 1 chunk +42 lines, -47 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
fschneider
9 years, 2 months ago (2011-10-13 08:44:23 UTC) #1
Kevin Millikin (Chromium)
Thanks a lot for catching and fixing this. As discussed offline, could we try a ...
9 years, 2 months ago (2011-10-13 14:16:20 UTC) #2
fschneider
9 years, 2 months ago (2011-10-14 08:14:54 UTC) #3
Uploaded new version. The type oracle code is a lot simpler now.

Powered by Google App Engine
This is Rietveld 408576698