Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Issue 8258004: Tweak omnibox parsing heuristics more: (Closed)

Created:
9 years, 2 months ago by Peter Kasting
Modified:
9 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Tweak omnibox parsing heuristics more: * UNKNOWN inputs with at least one non-host component get displayed as "possible navigations" (by setting |have_what_you_typed_match| true in HistoryURLProvider::DoAutocomplete()). * Inputs with at least two non-host components (generally) get treated as URLs by AutocompleteInput::Parse(). Technically these could be searches but intranet URLs are much more likely. * Allow more cases to be REQUESTED_URL, such as "user@host" + ctrl. I'm not sure these were ever intentionally excluded from the ctrl-enter handling, and I don't see why they should be. Also use url_parse::ParsePort(), which didn't use to exist (I think?) to replace some code in AutocompleteInput::Parse(). BUG=99131 TEST=Covered by unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105363

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -65 lines) Patch
M chrome/browser/autocomplete/autocomplete.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete.cc View 4 chunks +57 lines, -30 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_unittest.cc View 7 chunks +19 lines, -16 lines 0 comments Download
M chrome/browser/autocomplete/history_url_provider.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/autocomplete/history_url_provider_unittest.cc View 2 chunks +29 lines, -17 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Peter Kasting
9 years, 2 months ago (2011-10-13 00:47:30 UTC) #1
sky
9 years, 2 months ago (2011-10-13 14:56:55 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698