Issue 8256012: Remove some asserts to speed up debug mode.

Issue 8256012: Remove some asserts to speed up debug mode. (Closed)

Created:
9 years, 2 months ago by Erik Corry

Modified:
9 years, 2 months ago

Reviewers:
Vyacheslav Egorov (Chromium), Michael Starzinger

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Remove some asserts to speed up debug mode. Committed: http://code.google.com/p/v8/source/detail?r=9606

Patch Set 2 : '' #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -56 lines)			Patch
M	src/heap.cc	View	6 chunks	+12 lines, -11 lines	0 comments	Download
M	src/heap-inl.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/incremental-marking.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/incremental-marking-inl.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/mark-compact.h	View	4 chunks	+0 lines, -20 lines	0 comments	Download
M	src/mark-compact-inl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects-inl.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/spaces.h	View	6 chunks	+4 lines, -8 lines	0 comments	Download
M	src/spaces-inl.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	src/store-buffer-inl.h	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/utils.h	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM. http://codereview.chromium.org/8256012/diff/1/src/incremental-marking.cc File src/incremental-marking.cc (left): http://codereview.chromium.org/8256012/diff/1/src/incremental-marking.cc#oldcode745 src/incremental-marking.cc:745: (obj->IsFiller() && Marking::IsWhite(obj_mark_bit))); This one is a pretty ...

9 years, 2 months ago (2011-10-13 11:39:10 UTC) #3

Erik Corry

9 years, 2 months ago (2011-10-13 11:50:53 UTC) #4

http://codereview.chromium.org/8256012/diff/1/src/incremental-marking.cc
File src/incremental-marking.cc (left):

http://codereview.chromium.org/8256012/diff/1/src/incremental-marking.cc#oldc...
src/incremental-marking.cc:745: (obj->IsFiller() &&
Marking::IsWhite(obj_mark_bit)));
On 2011/10/13 11:39:10, Michael Starzinger wrote:
> This one is a pretty crucial assumption IMHO. I am kind of uncomfortable with
> removing this one completely. But if it has high impact we could remove it
> temporarily. But you are the GC experts. :)

I'll make it a slow assert.

Expand Messages | Collapse Messages