chrome/browser/ui/webui/html_dialog_tab_contents_delegate_unittest.cc - Issue 8253002: Move PageTransition into content namespace. While I'm touching all these files, I've also updated...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/html_dialog_tab_contents_delegate_unittest.cc

Issue 8253002: Move PageTransition into content namespace. While I'm touching all these files, I've also updated... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/browser_navigator_browsertest.cc ('K') | « chrome/browser/ui/webui/html_dialog_tab_contents_delegate.cc ('k') | chrome/browser/ui/webui/ntp/new_tab_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/html_dialog_tab_contents_delegate_unittest.cc

===================================================================

--- chrome/browser/ui/webui/html_dialog_tab_contents_delegate_unittest.cc (revision 105162)

+++ chrome/browser/ui/webui/html_dialog_tab_contents_delegate_unittest.cc (working copy)

@@ -57,7 +57,7 @@

scoped_refptr<history::HistoryAddPageArgs> should_add_args(

new history::HistoryAddPageArgs(

GURL(), base::Time::Now(), 0, 0, GURL(), history::RedirectList(),

- PageTransition::TYPED, history::SOURCE_SYNCED, false));

+ content::PAGE_TRANSITION_TYPED, history::SOURCE_SYNCED, false));

EXPECT_FALSE(test_tab_contents_delegate_->ShouldAddNavigationToHistory(

*should_add_args, NavigationType::NEW_PAGE));

test_tab_contents_delegate_->NavigationStateChanged(NULL, 0);

@@ -73,7 +73,7 @@

TEST_F(HtmlDialogTabContentsDelegateTest, OpenURLFromTabTest) {

test_tab_contents_delegate_->OpenURLFromTab(

NULL, GURL(chrome::kAboutBlankURL), GURL(),

- NEW_FOREGROUND_TAB, PageTransition::LINK);

+ NEW_FOREGROUND_TAB, content::PAGE_TRANSITION_LINK);

// This should create a new foreground tab in the existing browser.

EXPECT_EQ(1, browser()->tab_count());

EXPECT_EQ(1U, BrowserList::size());

@@ -96,7 +96,7 @@

// Now, none of the following calls should do anything.

test_tab_contents_delegate_->OpenURLFromTab(

NULL, GURL(chrome::kAboutBlankURL), GURL(),

- NEW_FOREGROUND_TAB, PageTransition::LINK);

+ NEW_FOREGROUND_TAB, content::PAGE_TRANSITION_LINK);

test_tab_contents_delegate_->AddNewContents(NULL, NULL, NEW_FOREGROUND_TAB,

gfx::Rect(), false);

EXPECT_EQ(0, browser()->tab_count());