chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc - Issue 8253002: Move PageTransition into content namespace. While I'm touching all these files, I've also updated...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

Issue 8253002: Move PageTransition into content namespace. While I'm touching all these files, I've also updated... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/browser_navigator_browsertest.cc ('K') | « chrome/browser/ui/views/about_chrome_view.cc ('k') | chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

===================================================================

--- chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc (revision 105162)

+++ chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc (working copy)

@@ -40,7 +40,7 @@

#include "content/browser/tab_contents/tab_contents.h"

#include "content/browser/user_metrics.h"

#include "content/common/notification_service.h"

-#include "content/common/page_transition_types.h"

+#include "content/public/common/page_transition_types.h"

#include "grit/generated_resources.h"

#include "grit/theme_resources.h"

#include "grit/ui_resources.h"

@@ -1064,7 +1064,7 @@

if (node->is_url()) {

RecordAppLaunch(profile, node->url());

page_navigator_->OpenURL(node->url(), GURL(),

- disposition_from_event_flags, PageTransition::AUTO_BOOKMARK);

+ disposition_from_event_flags, content::PAGE_TRANSITION_AUTO_BOOKMARK);

} else {

bookmark_utils::OpenAll(GetWidget()->GetNativeWindow(), profile,

page_navigator_, node, disposition_from_event_flags);