chrome/browser/ui/cocoa/view_id_util_browsertest.mm - Issue 8253002: Move PageTransition into content namespace. While I'm touching all these files, I've also updated...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/view_id_util_browsertest.mm

Issue 8253002: Move PageTransition into content namespace. While I'm touching all these files, I've also updated... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/browser_navigator_browsertest.cc ('K') | « chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm ('k') | chrome/browser/ui/find_bar/find_bar_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/view_id_util_browsertest.mm

===================================================================

--- chrome/browser/ui/cocoa/view_id_util_browsertest.mm (revision 105162)

+++ chrome/browser/ui/cocoa/view_id_util_browsertest.mm (working copy)

@@ -107,7 +107,7 @@

for (int i = 1; i <= 9; ++i) {

CheckViewID(static_cast<ViewID>(VIEW_ID_TAB_0 + i), false);

browser()->OpenURL(GURL(chrome::kAboutBlankURL), GURL(),

- NEW_BACKGROUND_TAB, PageTransition::TYPED);

+ NEW_BACKGROUND_TAB, content::PAGE_TRANSITION_TYPED);

CheckViewID(static_cast<ViewID>(VIEW_ID_TAB_0 + i), true);

// VIEW_ID_TAB_LAST should always be available.

CheckViewID(VIEW_ID_TAB_LAST, true);

@@ -115,6 +115,6 @@

// Open the 11th tab.

browser()->OpenURL(GURL(chrome::kAboutBlankURL), GURL(),

- NEW_BACKGROUND_TAB, PageTransition::TYPED);

+ NEW_BACKGROUND_TAB, content::PAGE_TRANSITION_TYPED);

CheckViewID(VIEW_ID_TAB_LAST, true);

}