chrome/browser/ui/webui/html_dialog_tab_contents_delegate.cc - Issue 8253002: Move PageTransition into content namespace. While I'm touching all these files, I've also updated...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/html_dialog_tab_contents_delegate.cc

Issue 8253002: Move PageTransition into content namespace. While I'm touching all these files, I've also updated... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/html_dialog_tab_contents_delegate.h ('k') | chrome/browser/ui/webui/html_dialog_tab_contents_delegate_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/html_dialog_tab_contents_delegate.cc

===================================================================

--- chrome/browser/ui/webui/html_dialog_tab_contents_delegate.cc (revision 105162)

+++ chrome/browser/ui/webui/html_dialog_tab_contents_delegate.cc (working copy)

@@ -31,7 +31,7 @@

// TODO(adriansc): Remove this method once refactoring changed all call sites.

TabContents* HtmlDialogTabContentsDelegate::OpenURLFromTab(

TabContents* source, const GURL& url, const GURL& referrer,

- WindowOpenDisposition disposition, PageTransition::Type transition) {

+ WindowOpenDisposition disposition, content::PageTransition transition) {

return OpenURLFromTab(source,

OpenURLParams(url, referrer, disposition, transition));

}

@@ -47,7 +47,7 @@

nav_params.referrer = params.referrer;

if (source && source->is_crashed() &&

params.disposition == CURRENT_TAB &&

- params.transition == PageTransition::LINK)

+ params.transition == content::PAGE_TRANSITION_LINK)

nav_params.disposition = NEW_FOREGROUND_TAB;

else

nav_params.disposition = params.disposition;