Add a basic backwards compatibility unittest.

Add a basic backwards compatibility unittest.

This verifies we can still apply old patches, but does not
verify that old clients can apply new patches. That seems
important, but I'm not sure how to do it without storing
old client binaries in version control.

Also refactors a number of unit tests to allow code sharing for
reading files into memory. This is done via a new base class.

Uses test binaries submitted seperatly because of build tools problems.

BUG=None
TEST=New Unittest


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105982

[dgarrett, 2011-10-13 22:49:16]

This adds the backwards compatibility unittest that caused problems before, and
addresses the issue of FileContents that came up in the initial review by
creating a base class that assorted tests can inherit from for helper methods.

[Michael Krebs, 2011-10-17 21:22:14]

http://codereview.chromium.org/8252011/diff/3009/courgette/base_test_unittest.h
File courgette/base_test_unittest.h (right):

http://codereview.chromium.org/8252011/diff/3009/courgette/base_test_unittest...
courgette/base_test_unittest.h:20: void SetUp();
I believe this and TearDown() should be marked as "virtual", since the base
class declares them as such.

http://codereview.chromium.org/8252011/diff/3009/courgette/image_info_unittes...
File courgette/image_info_unittest.cc (right):

http://codereview.chromium.org/8252011/diff/3009/courgette/image_info_unittes...
courgette/image_info_unittest.cc:14: protected:
Did you intend to change ExpectExecutable() to be protected instead of private?

[dgarrett, 2011-10-17 21:50:59]

Good?

http://codereview.chromium.org/8252011/diff/3009/courgette/base_test_unittest.h
File courgette/base_test_unittest.h (right):

http://codereview.chromium.org/8252011/diff/3009/courgette/base_test_unittest...
courgette/base_test_unittest.h:20: void SetUp();
On 2011/10/17 21:22:14, Michael Krebs wrote:
> I believe this and TearDown() should be marked as "virtual", since the base
> class declares them as such.

Done.

http://codereview.chromium.org/8252011/diff/3009/courgette/image_info_unittes...
File courgette/image_info_unittest.cc (right):

http://codereview.chromium.org/8252011/diff/3009/courgette/image_info_unittes...
courgette/image_info_unittest.cc:14: protected:
On 2011/10/17 21:22:14, Michael Krebs wrote:
> Did you intend to change ExpectExecutable() to be protected instead of
private?

No, but don't really care either way. I can switch it back.

[Michael Krebs, 2011-10-17 22:04:11]

lgtm

[commit-bot: I haz the power, 2011-10-17 22:27:52]

No LGTM from valid reviewers yet.

[sra1, 2011-10-17 22:56:19]

lgtm

[commit-bot: I haz the power, 2011-10-17 22:58:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dgarrett@chromium.org/8252011/7001

[commit-bot: I haz the power, 2011-10-18 01:08:37]

Change committed as 105982

[Paweł Hajdan Jr., 2011-10-19 08:46:39]

Drive-by with testing nits, please fix 'em.

http://codereview.chromium.org/8252011/diff/7001/courgette/base_test_unittest.cc
File courgette/base_test_unittest.cc (right):

http://codereview.chromium.org/8252011/diff/7001/courgette/base_test_unittest...
courgette/base_test_unittest.cc:10: PathService::Get(base::DIR_SOURCE_ROOT,
&test_dir_);
Please check return value.

http://codereview.chromium.org/8252011/diff/7001/courgette/base_test_unittest...
courgette/base_test_unittest.cc:24:
EXPECT_TRUE(file_util::ReadFileToString(file_path, &file_bytes));
Not sure if this test is valuable at all.

http://codereview.chromium.org/8252011/diff/7001/courgette/base_test_unittest.h
File courgette/base_test_unittest.h (right):

http://codereview.chromium.org/8252011/diff/7001/courgette/base_test_unittest...
courgette/base_test_unittest.h:5: #include <string>
What's that? It's included twice in this file, and this one is above the header
guards. Probably not intended.

http://codereview.chromium.org/8252011/diff/7001/courgette/base_test_unittest...
courgette/base_test_unittest.h:26: #endif // COURGETTE_BASE_TEST_UNITTEST_H_
nit: Two spaces before // please.

http://codereview.chromium.org/8252011/diff/7001/courgette/versioning_unittes...
File courgette/versioning_unittest.cc (right):

http://codereview.chromium.org/8252011/diff/7001/courgette/versioning_unittes...
courgette/versioning_unittest.cc:16: const char* patch_file,
nit: Indentation is off.

http://codereview.chromium.org/8252011/diff/7001/courgette/versioning_unittes...
courgette/versioning_unittest.cc:23: 
nit: Remove empty line.