Issue 825004: Adding missing file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 825004: Adding missing file. (Closed)

Created:
10 years, 9 months ago by Florian Loitsch

Modified:
9 years, 7 months ago

Reviewers:
William Hesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Adding missing file. Committed: http://code.google.com/p/v8/source/detail?r=4091

Patch Set 3 : '' #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+91 lines, -0 lines)			Patch
	A	test/cctest/test-dtoa.h	View	1 2	1 chunk	+91 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

William Hesse

LGTM with changes. http://codereview.chromium.org/825004/diff/1/2 File test/cctest/test-dtoa.h (right): http://codereview.chromium.org/825004/diff/1/2#newcode4 test/cctest/test-dtoa.h:4: char* buffer, int sign, int length, ...

10 years, 9 months ago (2010-03-10 21:02:42 UTC) #2

Florian Loitsch

10 years, 9 months ago (2010-03-10 21:08:16 UTC) #3

http://codereview.chromium.org/825004/diff/1/2
File test/cctest/test-dtoa.h (right):

http://codereview.chromium.org/825004/diff/1/2#newcode4
test/cctest/test-dtoa.h:4: char* buffer, int sign, int length, int point) {
On 2010/03/10 21:02:42, William Hesse wrote:
> One parameter per line.

Done.

http://codereview.chromium.org/825004/diff/1/2#newcode63
test/cctest/test-dtoa.h:63: double v, char* buffer, int sign, int length, int
point) {
On 2010/03/10 21:02:42, William Hesse wrote:
> Format formal parameters one per line.

Done.

http://codereview.chromium.org/825004/diff/1/2#newcode73
test/cctest/test-dtoa.h:73: if (v == ComposeDouble(buffer, sign, length - 1,
point))
On 2010/03/10 21:02:42, William Hesse wrote:
> Put braces around a statement if it is not on the same line as if.

Done.

Expand Messages | Collapse Messages

Issue 825004: Adding missing file. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages