Offline state detection for linux, using new D-Bus library.

net/base/network_change_notifier_linux.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_BASE_NETWORK_CHANGE_NOTIFIER_LINUX_H_
 #define NET_BASE_NETWORK_CHANGE_NOTIFIER_LINUX_H_
 #pragma once
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/memory/scoped_ptr.h"
 #include "net/base/network_change_notifier.h"
 
+namespace dbus {
+class Bus;
+}
+
 namespace net {
 
 class NetworkChangeNotifierLinux : public NetworkChangeNotifier {
  public:
   NetworkChangeNotifierLinux();
 
+  // Unittests inject a mock bus.
+  static NetworkChangeNotifierLinux* CreateForTest(dbus::Bus* bus) {

[satorux1, 2011/10/26 18:53:15]

I'm slightly worrying about inlining the function here, as clang tends to be
grumpy about it. Would be safer to move the definition to .cc file.

[adamk, 2011/10/26 19:09:34]

Done (though my memory is that clang cares more about inline virtuals than
inlines in general).

+    return new NetworkChangeNotifierLinux(bus);
+  }
+
+ protected:
+
  private:
   class Thread;
 
+  // For unittests.
+  explicit NetworkChangeNotifierLinux(dbus::Bus* bus);
+
   virtual ~NetworkChangeNotifierLinux();
 
   // NetworkChangeNotifier:
   virtual bool IsCurrentlyOffline() const OVERRIDE;
 
   // The thread used to listen for notifications.  This relays the notification
   // to the registered observers without posting back to the thread the object
   // was created on.
   scoped_ptr<Thread> notifier_thread_;
 
   DISALLOW_COPY_AND_ASSIGN(NetworkChangeNotifierLinux);
 };
 
 }  // namespace net
 
 #endif  // NET_BASE_NETWORK_CHANGE_NOTIFIER_LINUX_H_