Positions the launcher in the bottom left corner. Adds ShellDelegate

Positions the launcher in the bottom left corner. Adds ShellDelegate
API to allow configuring entries that are added to the
launcher. Changes LauncherModel not to include fixed buttons (create
new window and show apps buttons).

BUG=97262
TEST=none
R=ben@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105383

[Ben Goodger (Google), 2011-10-13 03:03:39]

http://codereview.chromium.org/8247012/diff/4001/ui/aura/window.h
File ui/aura/window.h (right):

http://codereview.chromium.org/8247012/diff/4001/ui/aura/window.h#newcode215
ui/aura/window.h:215: protected:
don't change this

http://codereview.chromium.org/8247012/diff/4001/ui/aura_shell/launcher/launc...
File ui/aura_shell/launcher/launcher_model.h (right):

http://codereview.chromium.org/8247012/diff/4001/ui/aura_shell/launcher/launc...
ui/aura_shell/launcher/launcher_model.h:51: static LauncherModel* instance_;
I'm not sure you'll want this to be global like this, think of multiple signed
in users.

http://codereview.chromium.org/8247012/diff/4001/ui/aura_shell/shell.cc
File ui/aura_shell/shell.cc (right):

http://codereview.chromium.org/8247012/diff/4001/ui/aura_shell/shell.cc#newco...
ui/aura_shell/shell.cc:251: void Shell::WindowAdded(aura::Window* window) {
Seems like you don't want to listen to all window adds/removes... just additions
to the DefaultWindowContainer. Other items wouldn't show up in the launcher...

Makes me think there should be a WindowObserver, and then the shell, as creator
of the DefaultWindowContainer, could register itself as an observer of that
particular window.

[sky, 2011-10-13 03:58:26]

On Wed, Oct 12, 2011 at 8:03 PM,  <ben@chromium.org> wrote:
>
> http://codereview.chromium.org/8247012/diff/4001/ui/aura/window.h
> File ui/aura/window.h (right):
>
> http://codereview.chromium.org/8247012/diff/4001/ui/aura/window.h#newcode215
> ui/aura/window.h:215: protected:
> don't change this

GAH! Fixed.

>
http://codereview.chromium.org/8247012/diff/4001/ui/aura_shell/launcher/launc...
> File ui/aura_shell/launcher/launcher_model.h (right):
>
>
http://codereview.chromium.org/8247012/diff/4001/ui/aura_shell/launcher/launc...
> ui/aura_shell/launcher/launcher_model.h:51: static LauncherModel*
> instance_;
> I'm not sure you'll want this to be global like this, think of multiple
> signed in users.

This is tied to your next point. I added a TODO. I would like to fix
it once we have observers. That'll make the linkages easier.

> http://codereview.chromium.org/8247012/diff/4001/ui/aura_shell/shell.cc
> File ui/aura_shell/shell.cc (right):
>
>
http://codereview.chromium.org/8247012/diff/4001/ui/aura_shell/shell.cc#newco...
> ui/aura_shell/shell.cc:251: void Shell::WindowAdded(aura::Window*
> window) {
> Seems like you don't want to listen to all window adds/removes... just
> additions to the DefaultWindowContainer. Other items wouldn't show up in
> the launcher...
>
> Makes me think there should be a WindowObserver, and then the shell, as
> creator of the DefaultWindowContainer, could register itself as an
> observer of that particular window.

Sadrul has a patch to add observers here:
http://codereview.chromium.org/8253001/ . I'm happy to migrate the
changes I've done to an observer model once landed. I was hoping to
land this before that. But if you prefer, I can wait.

  -Scott

[sky, 2011-10-13 19:13:30]

Updated. I created WindowObserver for the add/remove notifications and register
it on the toplevelwindowcontainer. I removed the LauncherModel::instance method
and made Shell own a Launcher instead of calling off to CreateLauncher.

  -Scott

[Ben Goodger (Google), 2011-10-13 19:39:15]

lgtm