Issue 8246004: Add negative test for setters in initializer list.

Issue 8246004: Add negative test for setters in initializer list. (Closed)

Created:
9 years, 2 months ago by floitsch

Modified:
9 years, 2 months ago

Reviewers:
mmendez, ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Description

Add negative test for setters in initializer list. Committed: https://code.google.com/p/dart/source/detail?r=399

Patch Set 2 : Address comment. #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -0 lines)			Patch
	M	tests/language/language.status	View		1 chunk	+1 line, -0 lines	0 comments	Download
	A	tests/language/src/ConstructorSetterNegativeTest.dart	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM http://codereview.chromium.org/8246004/diff/1/tests/language/src/ConstructorSetterNegativeTest.dart File tests/language/src/ConstructorSetterNegativeTest.dart (right): http://codereview.chromium.org/8246004/diff/1/tests/language/src/ConstructorSetterNegativeTest.dart#newcode4 tests/language/src/ConstructorSetterNegativeTest.dart:4: // Test that verifies that setters are not ...

9 years, 2 months ago (2011-10-13 15:01:18 UTC) #2

floitsch

http://codereview.chromium.org/8246004/diff/1/tests/language/src/ConstructorSetterNegativeTest.dart File tests/language/src/ConstructorSetterNegativeTest.dart (right): http://codereview.chromium.org/8246004/diff/1/tests/language/src/ConstructorSetterNegativeTest.dart#newcode4 tests/language/src/ConstructorSetterNegativeTest.dart:4: // Test that verifies that setters are not invokable ...

9 years, 2 months ago (2011-10-13 15:03:32 UTC) #3

mmendez

9 years, 2 months ago (2011-10-13 15:09:03 UTC) #4

LGTM

On 2011/10/13 15:03:32, floitsch wrote:
>
http://codereview.chromium.org/8246004/diff/1/tests/language/src/ConstructorS...
> File tests/language/src/ConstructorSetterNegativeTest.dart (right):
> 
>
http://codereview.chromium.org/8246004/diff/1/tests/language/src/ConstructorS...
> tests/language/src/ConstructorSetterNegativeTest.dart:4: // Test that verifies
> that setters are not invokable in the initializer list.
> On 2011/10/13 15:01:18, ngeoffray wrote:
> > Remove 'that verifies'.
> 
> Done.

Expand Messages | Collapse Messages