Issue 8245012: Revert 105087 - PrintPreview: Fix printer color settings issues based on printer ppd/schema infor...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8245012: Revert 105087 - PrintPreview: Fix printer color settings issues based on printer ppd/schema infor... (Closed)

Created:
9 years, 2 months ago by kmadhusu

Modified:
9 years, 2 months ago

Reviewers:
kmadhusu

CC:
chromium-reviews, arv (Not doing code reviews), Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 105087 - PrintPreview: Fix printer color settings issues based on printer ppd/schema information. Show/Hide the color options based on printer ppd/schema information. Some printers does not provide sufficient information in the printer schema/ppd regarding the color settings and they use custom advance settings to print in black & white/greyscale. In those cases, users need to print using native dialog in order to set these advance color settings. BUG=93811, 93490, 87344, 96658, 98768 TEST= Please refer to bug description. Review URL: http://codereview.chromium.org/8138020 TBR=kmadhusu@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105096

Patch Set 1 #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+404 lines, -1049 lines)			Patch
M	chrome/browser/printing/print_dialog_gtk.cc	View	2 chunks	+19 lines, -5 lines	0 comments	Download
D	chrome/browser/printing/print_system_task_proxy.h	View	1 chunk	+0 lines, -73 lines	0 comments	Download
D	chrome/browser/printing/print_system_task_proxy.cc	View	1 chunk	+0 lines, -543 lines	0 comments	Download
D	chrome/browser/printing/print_system_task_proxy_unittest.cc	View	1 chunk	+0 lines, -223 lines	0 comments	Download
M	chrome/browser/resources/print_preview/color_settings.js	View	3 chunks	+10 lines, -16 lines	0 comments	Download
M	chrome/browser/resources/print_preview/print_preview.js	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/webui/print_preview_handler.h	View	3 chunks	+16 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/print_preview_handler.cc	View	7 chunks	+344 lines, -11 lines	0 comments	Download
A +	chrome/browser/ui/webui/print_preview_handler_unittest.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	printing/print_job_constants.h	View	2 chunks	+2 lines, -38 lines	0 comments	Download
M	printing/print_job_constants.cc	View	1 chunk	+0 lines, -18 lines	0 comments	Download
MM	printing/print_settings.h	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	printing/print_settings.cc	View	1 chunk	+0 lines, -96 lines	0 comments	Download
MM	printing/printing_context_mac.mm	View	2 chunks	+11 lines, -9 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages