Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Side by Side Diff: src/assembler.h

Issue 8245007: Refactor how embedded pointers are visited. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments by Vyacheslav Egorov. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/assembler-arm-inl.h ('k') | src/ia32/assembler-ia32-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 212 matching lines...) Expand 10 before | Expand all | Expand 10 after
223 RelocInfo(byte* pc, Mode rmode, intptr_t data, Code* host) 223 RelocInfo(byte* pc, Mode rmode, intptr_t data, Code* host)
224 : pc_(pc), rmode_(rmode), data_(data), host_(host) { 224 : pc_(pc), rmode_(rmode), data_(data), host_(host) {
225 } 225 }
226 226
227 static inline bool IsConstructCall(Mode mode) { 227 static inline bool IsConstructCall(Mode mode) {
228 return mode == CONSTRUCT_CALL; 228 return mode == CONSTRUCT_CALL;
229 } 229 }
230 static inline bool IsCodeTarget(Mode mode) { 230 static inline bool IsCodeTarget(Mode mode) {
231 return mode <= LAST_CODE_ENUM; 231 return mode <= LAST_CODE_ENUM;
232 } 232 }
233 static inline bool IsEmbeddedObject(Mode mode) {
234 return mode == EMBEDDED_OBJECT;
235 }
233 // Is the relocation mode affected by GC? 236 // Is the relocation mode affected by GC?
234 static inline bool IsGCRelocMode(Mode mode) { 237 static inline bool IsGCRelocMode(Mode mode) {
235 return mode <= LAST_GCED_ENUM; 238 return mode <= LAST_GCED_ENUM;
236 } 239 }
237 static inline bool IsJSReturn(Mode mode) { 240 static inline bool IsJSReturn(Mode mode) {
238 return mode == JS_RETURN; 241 return mode == JS_RETURN;
239 } 242 }
240 static inline bool IsComment(Mode mode) { 243 static inline bool IsComment(Mode mode) {
241 return mode == COMMENT; 244 return mode == COMMENT;
242 } 245 }
(...skipping 623 matching lines...) Expand 10 before | Expand all | Expand 10 after
866 public: 869 public:
867 NullCallWrapper() { } 870 NullCallWrapper() { }
868 virtual ~NullCallWrapper() { } 871 virtual ~NullCallWrapper() { }
869 virtual void BeforeCall(int call_size) const { } 872 virtual void BeforeCall(int call_size) const { }
870 virtual void AfterCall() const { } 873 virtual void AfterCall() const { }
871 }; 874 };
872 875
873 } } // namespace v8::internal 876 } } // namespace v8::internal
874 877
875 #endif // V8_ASSEMBLER_H_ 878 #endif // V8_ASSEMBLER_H_
OLDNEW
« no previous file with comments | « src/arm/assembler-arm-inl.h ('k') | src/ia32/assembler-ia32-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698