Issue 8244002: GTK: Show avatar menu from NTP

Issue 8244002: GTK: Show avatar menu from NTP (Closed)

Created:
9 years, 2 months ago by sail

Modified:
9 years, 2 months ago

Reviewers:
commit-bot: I haz the power, Elliot Glaysher, binji

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -5 lines)			Patch
M	chrome/browser/ui/gtk/avatar_menu_bubble_gtk.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/avatar_menu_bubble_gtk.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/gtk/avatar_menu_button_gtk.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/browser_window_gtk.cc	View	2 chunks	+4 lines, -1 line	0 comments	Download

Total messages: 7 (0 generated)

Elliot Glaysher

On 2011/10/12 09:12:01, sail wrote: > binji: avatar code > erg: Gtk lgtm but you ...

9 years, 2 months ago (2011-10-12 17:50:25 UTC) #2

sail

> lgtm but you probably want to add bug number to the template. Done! Thanks ...

9 years, 2 months ago (2011-10-12 17:55:07 UTC) #3

binji

On 2011/10/12 17:55:07, sail wrote: > > lgtm but you probably want to add bug ...

9 years, 2 months ago (2011-10-12 17:58:15 UTC) #4

sail

> lgtm, but it doesn't look like avatar_menu_bubble_gtk is checked in yet...? It doesn't hurt ...

9 years, 2 months ago (2011-10-12 18:00:30 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/8244002/1

9 years, 2 months ago (2011-10-13 23:08:42 UTC) #6

Change committed as 105442