Issue 8243012: Fix build with system yasm.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8243012: Fix build with system yasm. (Closed)

Created:
9 years, 2 months ago by Paweł Hajdan Jr.

Modified:
9 years, 2 months ago

Reviewers:
awong

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix build with system yasm. BUG=100078 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105149

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -5 lines)			Patch
M	DEPS	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	build/common.gypi	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	third_party/yasm/yasm_compile.gypi	View		2 chunks	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

This depends on http://codereview.chromium.org/8226030/, http://codereview.chromium.org/8241019/, and http://codereview.chromium.org/8244015/ After those CLs land I'll roll DEPS in ...

9 years, 2 months ago (2011-10-12 18:56:20 UTC) #1

LGTM

Expand Messages | Collapse Messages