Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 8243010: Queue callbacks in PluginService::GetPlugins. (Closed)

Created:
9 years, 2 months ago by Bernhard Bauer
Modified:
9 years, 1 month ago
Reviewers:
Robert Sesek, jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, Robert Sesek
Visibility:
Public.

Description

Queue callbacks in PluginService::GetPlugins. This avoids spawning multiple processes in parallel that load plug-ins. BUG=none TEST=none

Patch Set 1 #

Patch Set 2 : move pluginloader to separate file #

Patch Set 3 : '' #

Patch Set 4 : fix linux compile #

Patch Set 5 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -70 lines) Patch
A content/browser/plugin_loader.h View 1 2 1 chunk +58 lines, -0 lines 0 comments Download
A content/browser/plugin_loader.cc View 1 2 1 chunk +81 lines, -0 lines 0 comments Download
M content/browser/plugin_service.h View 1 2 3 3 chunks +11 lines, -0 lines 0 comments Download
M content/browser/plugin_service.cc View 1 4 chunks +17 lines, -70 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bernhard Bauer
Please review.
9 years, 2 months ago (2011-10-13 16:32:39 UTC) #1
Robert Sesek
I'm actually in the process of doing this already as part of http://code.google.com/p/chromium/issues/detail?id=100053. I'd prefer ...
9 years, 2 months ago (2011-10-13 16:55:43 UTC) #2
Bernhard Bauer
9 years, 2 months ago (2011-10-13 17:12:52 UTC) #3
On 2011/10/13 16:55:43, rsesek wrote:
> I'm actually in the process of doing this already as part of
> http://code.google.com/p/chromium/issues/detail?id=100053. I'd prefer to not
> commit this so I don't have to do a heinous merge/rebase.

Oops :) Okay then, good to know this is being taken care of.

Powered by Google App Engine
This is Rietveld 408576698