Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 8243008: Remove references to GeolocationContentSettingsMap. (Closed)

Created:
9 years, 2 months ago by Bernhard Bauer
Modified:
9 years, 2 months ago
CC:
chromium-reviews, Paweł Hajdan Jr., markusheintz_
Visibility:
Public.

Description

Remove references to GeolocationContentSettingsMap. BUG=63656 TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105314

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -323 lines) Patch
D chrome/browser/geolocation/geolocation_content_settings_map_unittest.cc View 1 chunk +0 lines, -317 lines 0 comments Download
M chrome/browser/geolocation/geolocation_settings_state.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_notification_types.h View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Bernhard Bauer
Please review.
9 years, 2 months ago (2011-10-13 14:16:02 UTC) #1
marja
Afaics this CL only removes dead code (geolocation_content_settings_map_unittest.cc wasn't even compiled), so, LGTM.
9 years, 2 months ago (2011-10-13 14:29:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/8243008/1
9 years, 2 months ago (2011-10-13 14:45:59 UTC) #3
commit-bot: I haz the power
9 years, 2 months ago (2011-10-13 17:09:06 UTC) #4
Change committed as 105314

Powered by Google App Engine
This is Rietveld 408576698