Do not use Chrome plugins with ASan.

Do not use Chrome plugins with ASan.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105102

[Alexander Potapenko, 2011-10-12 15:40:39]

Nico,

is this enough not to run the Chrome style plugins for ASan builds?

[Nico, 2011-10-12 15:42:56]

probably. try it locally – if it works, it works :-P

http://codereview.chromium.org/8242011/diff/1/build/common.gypi
File build/common.gypi (right):

http://codereview.chromium.org/8242011/diff/1/build/common.gypi#newcode846
build/common.gypi:846: 'clang_use_chrome_plugins%': 0,
add a comment why

[Alexander Potapenko, 2011-10-12 16:35:31]

On 2011/10/12 15:42:56, Nico wrote:
> probably. try it locally – if it works, it works :-P
> 
It does, I just wanted to foresee the pitfalls, if any.

> http://codereview.chromium.org/8242011/diff/1/build/common.gypi
> File build/common.gypi (right):
> 
> http://codereview.chromium.org/8242011/diff/1/build/common.gypi#newcode846
> build/common.gypi:846: 'clang_use_chrome_plugins%': 0,
> add a comment why
Done

[Nico, 2011-10-12 16:37:34]

lgtm

http://codereview.chromium.org/8242011/diff/4001/build/common.gypi
File build/common.gypi (right):

http://codereview.chromium.org/8242011/diff/4001/build/common.gypi#newcode848
build/common.gypi:848: # not want additional warnings when building with ASan.
The tree goes red if the style plugin warns on anything, so "Second" isn't true
I think. "First" is a good reason, though.

[Alexander Potapenko, 2011-10-12 16:43:44]

http://codereview.chromium.org/8242011/diff/4001/build/common.gypi#newcode848
> build/common.gypi:848: # not want additional warnings when building with ASan.
> The tree goes red if the style plugin warns on anything, so "Second" isn't
true
> I think. "First" is a good reason, though.
Ok, I'll leave just the first one. In fact there should be no new warnings under
ASan, but for some reason I do observe some of them.