Issue 8241012: Enable accelerated WebKit compositor for Aura.

Issue 8241012: Enable accelerated WebKit compositor for Aura. (Closed)

Created:
9 years, 2 months ago by jonathan.backer

Modified:
9 years, 2 months ago

Reviewers:
Ben Goodger (Google), apatrick_chromium

CC:
chromium-reviews, dpranke+watch-content_chromium.org, jam, apatrick_chromium, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, piman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Enable accelerated WebKit compositor for Aura. This allows the use of the WebKit compositor for Aura on Linux. It reuses the same display path as TOUCH_UI. BUG=none TEST=build GYP_DEFINES="use_aura" on Linux; go to http://www.webkit.org/blog-files/3d-transforms/poster-circle.html Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105323

Patch Set 3 : Address reviewer comments. #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+150 lines, -118 lines)			Patch
M	build/common.gypi	View	1 2	3 chunks	+12 lines, -0 lines	0 comments	Download
M	chrome/browser/renderer_host/render_widget_host_view_views.h	View	1 2	5 chunks	+9 lines, -3 lines	0 comments	Download
M	chrome/browser/renderer_host/render_widget_host_view_views.cc	View	1 2	5 chunks	+79 lines, -5 lines	0 comments	Download
M	chrome/browser/renderer_host/render_widget_host_view_views_touch.cc	View		3 chunks	+0 lines, -71 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 2	3 chunks	+20 lines, -14 lines	0 comments	Download
M	content/browser/gpu/gpu_process_host_ui_shim.h	View	1 2	2 chunks	+5 lines, -4 lines	0 comments	Download
M	content/browser/gpu/gpu_process_host_ui_shim.cc	View	1 2	6 chunks	+7 lines, -7 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	content/common/gpu/gpu_command_buffer_stub.cc	View	1 2	6 chunks	+9 lines, -7 lines	0 comments	Download
M	content/common/gpu/gpu_messages.h	View	1 2	5 chunks	+7 lines, -5 lines	0 comments	Download
M	content/content_common.gypi	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

LGTM for the build/rwhv bits. http://codereview.chromium.org/8241012/diff/3001/build/common.gypi File build/common.gypi (right): http://codereview.chromium.org/8241012/diff/3001/build/common.gypi#newcode945 build/common.gypi:945: 'defines': ['VIEWS_GPU_IMAGE_TRANSPORT'], The only ...

9 years, 2 months ago (2011-10-12 18:22:58 UTC) #2

jonathan.backer

9 years, 2 months ago (2011-10-12 21:59:07 UTC) #4

On 2011/10/12 19:39:37, apatrick_chromium wrote:
> LGTM

+piman as CC:

Expand Messages | Collapse Messages