Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: src/code-stubs.cc

Issue 8241003: Elements kind conversion in generated code (ia32). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Applied suggested changes. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/code-stubs.h ('k') | src/ia32/code-stubs-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 397 matching lines...) Expand 10 before | Expand all | Expand 10 after
408 || Contains(ToBooleanStub::HEAP_NUMBER); 408 || Contains(ToBooleanStub::HEAP_NUMBER);
409 } 409 }
410 410
411 411
412 bool ToBooleanStub::Types::CanBeUndetectable() const { 412 bool ToBooleanStub::Types::CanBeUndetectable() const {
413 return Contains(ToBooleanStub::SPEC_OBJECT) 413 return Contains(ToBooleanStub::SPEC_OBJECT)
414 || Contains(ToBooleanStub::STRING); 414 || Contains(ToBooleanStub::STRING);
415 } 415 }
416 416
417 417
418 void FastElementsConversionStub::Generate(MacroAssembler* masm) {
419 #if defined(V8_TARGET_ARCH_IA32)
420 if (to_ == FAST_ELEMENTS) {
421 if (from_ == FAST_SMI_ONLY_ELEMENTS) {
422 GenerateSmiOnlyToObject(masm);
423 } else if (from_ == FAST_DOUBLE_ELEMENTS) {
424 GenerateDoubleToObject(masm, strict_mode_);
425 } else {
426 UNREACHABLE();
427 }
428 KeyedStoreStubCompiler::GenerateStoreFastElement(masm,
429 is_jsarray_,
430 FAST_ELEMENTS);
431 } else if (from_ == FAST_SMI_ONLY_ELEMENTS && to_ == FAST_DOUBLE_ELEMENTS) {
432 GenerateSmiOnlyToDouble(masm, strict_mode_);
433 KeyedStoreStubCompiler::GenerateStoreFastDoubleElement(masm, is_jsarray_);
434 } else {
435 UNREACHABLE();
436 }
437 #else
438 KeyedStoreIC::GenerateRuntimeSetProperty(masm, strict_mode_);
439 #endif // V8_TARGET_ARCH_IA32
440 }
441
418 } } // namespace v8::internal 442 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/code-stubs.h ('k') | src/ia32/code-stubs-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698