Handle bug 5442338: PCDescriptors generated wrongly, disallowing optimizations, causing assert fa...

runtime/vm/code_generator.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/code_generator.h"
 
 #include "vm/code_index_table.h"
 #include "vm/code_patcher.h"
 #include "vm/compiler.h"
 #include "vm/dart_entry.h"
@@ skipping 797 matching lines @@
 }
 
 
 // Only unoptimized code has invocation counter threshold checking.
 // Once the invocation counter threshold is reached any entry into the
 // unoptimized code is redirected to this function.
 DEFINE_RUNTIME_ENTRY(OptimizeInvokedFunction, 1) {
   ASSERT(arguments.Count() ==
          kOptimizeInvokedFunctionRuntimeEntry.argument_count());
   const Function& function = Function::CheckedHandle(arguments.At(0));
-  ASSERT(function.is_optimizable());
-  ASSERT(!Code::Handle(function.code()).is_optimized());
-  const Code& unoptimized_code = Code::Handle(function.code());
-  // Compilation patches the entry of unoptimized code.
-  Compiler::CompileOptimizedFunction(function);
-  const Code& optimized_code = Code::Handle(function.code());
-  ASSERT(!optimized_code.IsNull());
-  ASSERT(!unoptimized_code.IsNull());
-  DisableOldCode(function, unoptimized_code, optimized_code);
+  if (function.is_optimizable()) {
+    ASSERT(!Code::Handle(function.code()).is_optimized());
+    const Code& unoptimized_code = Code::Handle(function.code());
+    // Compilation patches the entry of unoptimized code.
+    Compiler::CompileOptimizedFunction(function);
+    const Code& optimized_code = Code::Handle(function.code());
+    ASSERT(!optimized_code.IsNull());
+    ASSERT(!unoptimized_code.IsNull());
+    DisableOldCode(function, unoptimized_code, optimized_code);
+  } else {
+    // TODO(5442338): Abort as this should not happen.
+    function.set_invocation_counter(0);
+  }
 }
 
 
 // The caller must be a static call in a Dart frame, or an entry frame.
 // Patch static call to point to 'new_entry_point'.
 DEFINE_RUNTIME_ENTRY(FixCallersTarget, 1) {
   ASSERT(arguments.Count() == kFixCallersTargetRuntimeEntry.argument_count());
   const Function& function = Function::CheckedHandle(arguments.At(0));
   ASSERT(!function.IsNull());
   ASSERT(function.HasCode());
@@ skipping 151 matching lines @@
       }
     }
   }
   // The cache is null terminated, therefore the loop above should never
   // terminate by itself.
   UNREACHABLE();
   return Code::null();
 }
 
 }  // namespace dart