Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Side by Side Diff: chrome/common/string_ordinal.h

Issue 8236002: Create StringOrdinal to allow placement of strings in sorted lists (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Small cleanup Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CHROME_COMMON_STRING_ORDINAL_H_
6 #define CHROME_COMMON_STRING_ORDINAL_H_
7 #pragma once
8
9 #include <string>
10
11 // A StringOrdinal represents a specially-formatted string that can be used
12 // for ordering. The StringOrdinal class has an unbounded dense strict total
13 // order, which mean for any StringOrdinals a, b and c:
14 //
15 // - a < b and b < c implies a < c (transitivity);
16 // - exactly one of a < b, b < a and a = b holds (trichotomy);
17 // - if a < b, there is a StringOrdinal x such that a < x < b (density);
18 // - there are StringOrdinals x and y such that x < a < y (unboundedness).
19 //
20 // This means that when StringOrdinal is used for sorting a list, if
21 // any item changes its position in the list, only its StringOrinal value
akalin 2011/10/20 19:06:51 Orinal -> Ordinal
22 // has to change to represent the new order, and all the other older values
23 // can stay the same.
24 class StringOrdinal {
25 public:
26 // Create a StringOrdinal from the given string. It may be valid or invalid.
27 explicit StringOrdinal(const std::string& string_ordinal);
28
29 // Create an invalid StringOrdinal.
akalin 2011/10/20 19:06:51 please revert this back to the default constructor
30 static StringOrdinal Invalid();
31
32 bool IsValid() const;
33
34 // All remaining functions can only be called if IsValid() holds.
35 // It is an error to call them if IsValid() is false.
36
37 // Ordering Functions
38
39 // Returns true iff |*this| < |other|.
40 bool LessThan(const StringOrdinal& other) const;
41
42 // Return true iff |*this| == |other| (i.e. this->LessThan(other) and
akalin 2011/10/20 19:06:51 say (i.e., |*this| < |other| and |*this| > |other
43 // other.LessThan(*this) are both false).
44 bool Equal(const StringOrdinal& other) const;
45
46 // Given |*this| != |other|, returns a StringOrdinal x such that
47 // min(|*this|, |other|) < x < max(|*this|, |other|). It is an error
48 // to call this function with |*this| == |other|.
akalin 2011/10/20 19:06:51 with -> when
49 StringOrdinal CreateBetween(const StringOrdinal& other) const;
50
51 // Returns a StringOrdinal x such that x < |*this|.
akalin 2011/10/20 19:06:51 x -> |x|
52 StringOrdinal CreateBefore() const;
53
54 // Returns a StringOrdinal x such that |*this| < x.
akalin 2011/10/20 19:06:51 x -> |x|
55 StringOrdinal CreateAfter() const;
56
57 // It is guaranteed that a StringOrdinal constructed from the returned
58 // string will be valid.
59 std::string ToString() const;
60
61 private:
62 // The value of the StringOrdinal.
akalin 2011/10/20 19:06:51 value -> string representation
63 std::string string_ordinal_;
64
65 // The validity of the StringOrdinal (is it of the format [a-z]*[b-z]),
akalin 2011/10/20 19:06:51 "is it" -> "i.e., is it"
66 // created to cache validity to prevent frequent recalculations.
67 bool is_valid_;
68
69 // Use of copy constructor and default assignment for this class is allowed.
70 };
71
72 #endif // CHROME_COMMON_STRING_ORDINAL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698