Inline allocation of implicit closures.

runtime/vm/code_generator.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/code_generator.h"
 
 #include "vm/code_index_table.h"
 #include "vm/code_patcher.h"
 #include "vm/compiler.h"
 #include "vm/dart_entry.h"
@@ skipping 204 matching lines @@
          (instantiator.Length() != type_arguments.Length()));
   type_arguments = TypeArguments::NewInstantiatedTypeArguments(type_arguments,
                                                                instantiator);
   arguments.SetReturn(type_arguments);
 }
 
 
 // Allocate a new closure.
 // Arg0: local function.
 // TODO(regis): Arg1: type arguments of the closure.
-// TODO(regis): Arg2: type arguments of the instantiator.
 // Return value: newly allocated closure.
 DEFINE_RUNTIME_ENTRY(AllocateClosure, 1) {
   ASSERT(arguments.Count() == kAllocateClosureRuntimeEntry.argument_count());
   const Function& function = Function::CheckedHandle(arguments.At(0));
+  ASSERT(function.IsClosureFunction() && !function.IsImplicitClosureFunction());
   // TODO(regis): Process type arguments unless the closure is static.
   // The current context was saved in the Isolate structure when entering the
   // runtime.
   const Context& context = Context::Handle(Isolate::Current()->top_context());
   ASSERT(!context.IsNull());
   arguments.SetReturn(Closure::Handle(Closure::New(function, context)));
 }
 
 
-// Allocate a new static implicit closure.
+// Allocate a new implicit static closure.
 // Arg0: local function.
 // Return value: newly allocated closure.
-DEFINE_RUNTIME_ENTRY(AllocateStaticImplicitClosure, 1) {
+DEFINE_RUNTIME_ENTRY(AllocateImplicitStaticClosure, 1) {
   ASSERT(arguments.Count() ==
-         kAllocateStaticImplicitClosureRuntimeEntry.argument_count());
+         kAllocateImplicitStaticClosureRuntimeEntry.argument_count());
   ObjectStore* object_store = Isolate::Current()->object_store();
   ASSERT(object_store != NULL);
   const Function& function = Function::CheckedHandle(arguments.At(0));
-  ASSERT(function.is_static());  // Closure functions are always static for now.
+  ASSERT(function.IsImplicitStaticClosureFunction());
   const Context& context = Context::Handle(object_store->empty_context());
   arguments.SetReturn(Closure::Handle(Closure::New(function, context)));
 }
 
 
-// Allocate a new implicit closure.
+// Allocate a new implicit instance closure.
 // Arg0: local function.
 // Arg1: receiver object.
 // TODO(regis): Arg2: type arguments of the closure.
-// TODO(regis): Arg3: type arguments of the instantiator.
 // Return value: newly allocated closure.
-DEFINE_RUNTIME_ENTRY(AllocateImplicitClosure, 2) {
+DEFINE_RUNTIME_ENTRY(AllocateImplicitInstanceClosure, 2) {
   ASSERT(arguments.Count() ==
-         kAllocateImplicitClosureRuntimeEntry.argument_count());
+         kAllocateImplicitInstanceClosureRuntimeEntry.argument_count());
   const Function& function = Function::CheckedHandle(arguments.At(0));
-  ASSERT(function.is_static());  // Closure functions are always static for now.
+  ASSERT(function.IsImplicitInstanceClosureFunction());
   const Instance& receiver = Instance::CheckedHandle(arguments.At(1));
   Context& context = Context::Handle();
   context = Context::New(1);
   context.SetAt(0, receiver);
   arguments.SetReturn(Closure::Handle(Closure::New(function, context)));
   // TODO(regis): Set type arguments.
 }
 
 
 // Allocate a new context large enough to hold the given number of variables.
@@ skipping 714 matching lines @@
       }
     }
   }
   // The cache is null terminated, therefore the loop above should never
   // terminate by itself.
   UNREACHABLE();
   return Code::null();
 }
 
 }  // namespace dart