Inline allocation of implicit closures.

runtime/vm/object.h

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_OBJECT_H_
 #define VM_OBJECT_H_
 
 #include "vm/assert.h"
 #include "vm/globals.h"
 #include "vm/handles.h"
@@ skipping 1121 matching lines @@
   bool IsSubtypeOf(const Function& other) const {
     return TestType(kIsSubtypeOf, other);
   }
 
   // Returns true if the type of this function can be assigned to the type of
   // the destination function.
   bool IsAssignableTo(const Function& dst) const {
     return TestType(kIsAssignableTo, dst);
   }
 
-  // Returns true if this function represents a closure function.
+  // Returns true if this function represents a (possibly implicit) closure
+  // function.
   bool IsClosureFunction() const {
     return kind() == RawFunction::kClosureFunction;
   }
 
+  // Returns true if this function represents an implicit closure function.
+  bool IsImplicitClosureFunction() const;

[siva, 2011/10/11 21:00:46]

I am wondering if it would be more readable if we
had
bool IsRegularClosureFunction() const;
bool IsStaticImplicitClosureFunction() const;
bool IsDynamicImplicitClosureFunction() const;

[regis, 2011/10/11 23:40:19]

I'd like to keep IsClosureFunction() to return true for all forms, otherwise you
need to OR all forms.

I do not like "Dynamic" (because of the coming renaming of var to Dynamic), but
prefer "Instance".

I added helpers as you suggested, bu with slightly different names.

+
   // Returns true if this function represents a local function.
   bool IsLocalFunction() const {
     return parent_function() != Function::null();
   }
 
   // Returns true if this function represents a signature function without code.
   bool IsSignatureFunction() const {
     return kind() == RawFunction::kSignatureFunction;
   }
 
@@ skipping 1632 matching lines @@
 }
 
 
 void Context::SetAt(intptr_t index, const Instance& value) const {
   StorePointer(InstanceAddr(index), value.raw());
 }
 
 }  // namespace dart
 
 #endif  // VM_OBJECT_H_