Inline allocation of implicit closures.

runtime/vm/object.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/object.h"
 
 #include "vm/assembler.h"
 #include "vm/assert.h"
 #include "vm/bigint_operations.h"
 #include "vm/bootstrap.h"
@@ skipping 2699 matching lines @@
       }
     }
     if (!found_param_name) {
       return false;
     }
   }
   return true;
 }
 
 
+bool Function::IsImplicitClosureFunction() const {
+  if (kind() != RawFunction::kClosureFunction) {
+    return false;
+  }

[siva, 2011/10/11 21:00:46]

if (!IsClosureFunction()) {
  return false;
}

instead of the explicit kind() check ?

[regis, 2011/10/11 23:40:19]

Done.

+  const Function& parent = Function::Handle(parent_function());
+  return parent.raw_ptr()->implicit_closure_function_ == raw();
+}
+
+
 RawFunction* Function::New() {
   const Class& function_class = Class::Handle(Object::function_class());
   RawObject* raw = Object::Allocate(function_class,
                                     Function::InstanceSize(),
                                     Heap::kOld);
   return reinterpret_cast<RawFunction*>(raw);
 }
 
 
 RawFunction* Function::New(const String& name,
@@ skipping 20 matching lines @@
 
 RawFunction* Function::NewClosureFunction(const String& name,
                                           const Function& parent,
                                           intptr_t token_index) {
   ASSERT(!parent.IsNull());
   const Class& parent_class = Class::Handle(parent.owner());
   ASSERT(!parent_class.IsNull());
   const Function& result = Function::Handle(
       Function::New(name,
                     RawFunction::kClosureFunction,
-                    /* is_static = */ true,
+                    /* is_static = */ parent.is_static(),
                     /* is_const = */ false,
                     token_index));
   result.set_parent_function(parent);
   result.set_owner(parent_class);
   return result.raw();
 }
 
 
 RawFunction* Function::ImplicitClosureFunction() const {
   // Return the existing implicit closure function if any.
@@ skipping 52 matching lines @@
     signature_class = Class::NewSignatureClass(signature,
                                                closure_function,
                                                script,
                                                token_index());
     library.AddClass(signature_class);
   }
   ASSERT(!Function::Handle(signature_class.signature_function()).IsNull());
   ASSERT(Class::Handle(closure_function.signature_class()).IsNull());
   closure_function.set_signature_class(signature_class);
   set_implicit_closure_function(closure_function);
+  ASSERT(closure_function.IsImplicitClosureFunction());
   return closure_function.raw();
 }
 
 
 template<typename T>
 static RawArray* NewArray(const GrowableArray<T*>& objs) {
   Array& a = Array::Handle(Array::New(objs.length(), Heap::kOld));
   for (int i = 0; i < objs.length(); i++) {
     a.SetAt(i, *objs[i]);
   }
@@ skipping 3441 matching lines @@
   const String& str = String::Handle(pattern());
   const char* format = "JSRegExp: pattern=%s flags=%s";
   intptr_t len = OS::SNPrint(NULL, 0, format, str.ToCString(), Flags());
   char* chars = reinterpret_cast<char*>(
       Isolate::Current()->current_zone()->Allocate(len + 1));
   OS::SNPrint(chars, (len + 1), format, str.ToCString(), Flags());
   return chars;
 }
 
 }  // namespace dart