SpellCheck refactoring: Moved user custom dictionary for spell check to SpellCheckProfile.

chrome/browser/profiles/profile_impl.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_impl.h"
 
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
 #include "base/environment.h"
 #include "base/file_path.h"
@@ skipping 1741 matching lines @@
 chrome_browser_net::Predictor* ProfileImpl::GetNetworkPredictor() {
   return predictor_;
 }
 
 void ProfileImpl::ClearNetworkingHistorySince(base::Time time) {
   io_data_.ClearNetworkingHistorySince(time);
 }
 
 SpellCheckProfile* ProfileImpl::GetSpellCheckProfile() {
   if (!spellcheck_profile_.get())
-    spellcheck_profile_.reset(new SpellCheckProfile());
+    spellcheck_profile_ = new SpellCheckProfile();

[Miranda Callahan, 2011/10/12 14:33:05]

scoped_ptr still uses the .reset function.

[shinyak (Google), 2011/10/13 07:51:22]

I've changed SpellCheckProfile ref-counted object (in order to keep it alive
until receiving save task or something like that). So I made spellcheck_profile_
scoped_refptr instead of scoped_ptr. scoped_refptr does not have reset() method.

[Hironori Bono, 2011/10/13 09:29:59]

Is it possible to describe more details about why you need scoped_refptr<>? (As
written in Issue 79886, we are trying to remove scoped_refptr<> from
ProfileImpl.)

[Miranda Callahan, 2011/10/13 14:33:12]

My apologies, you're right, of course -- I don't know what happened to my brain
-- I looked at the .h file several times, too. :-/

Having said that -- I agree with hbono about trying to remove scoped_refptr from
Profile -- it would be great if it were possible to avoid this change!

   return spellcheck_profile_.get();
 }
 
 void ProfileImpl::SetDownloadManagerDelegate(
     ChromeDownloadManagerDelegate* delegate) {
   download_manager_delegate_ = delegate;
 }