Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 8233039: Link startup_helper_win statically into executables (Closed)

Created:
9 years, 2 months ago by Dirk Pranke
Modified:
9 years, 2 months ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, dpranke+watch-content_chromium.org, jam
Visibility:
Public.

Description

Link startup_helper_win statically to force InitializeSandboxInfo to use the sandbox library linked statically into an executable; using a sandbox library linked into content.dll doesn't work on windows. R=jam@chromium.org BUG=90442 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105238

Patch Set 1 #

Patch Set 2 : fix missing sandbox dependencies #

Patch Set 3 : remove dynamic-only changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -5 lines) Patch
M chrome/chrome_tests.gypi View 6 chunks +6 lines, -0 lines 0 comments Download
M content/app/startup_helper_win.h View 2 chunks +5 lines, -5 lines 0 comments Download
M content/content_shell.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 1 4 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Dirk Pranke
9 years, 2 months ago (2011-10-12 01:43:11 UTC) #1
jam
9 years, 2 months ago (2011-10-12 03:04:13 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698