Update Breakpad to r863

Update Breakpad to r864, picking up some Mac refactorings and adjusting the
build configuration appropriately. This update also contains Clang warning
fixes and allows Breakpad's checkout in Chrome to pull its svn:externals.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104934

[Mark Mentovai, 2011-10-11 18:06:50]

Here is the complete revision log (svn log -r845:862
http://google-breakpad.googlecode.com/svn/trunk):

------------------------------------------------------------------------
r845 | qsr@chromium.org | 2011-10-06 09:24:35 -0400 (Thu, 06 Oct 2011) | 6 lines

 Adding svn:ignore properties for .deps and .dirstamp

 Remove spurious .distamp from the repository.

 LGTM from stuartmorgan.

------------------------------------------------------------------------
r846 | qsr@chromium.org | 2011-10-06 09:27:38 -0400 (Thu, 06 Oct 2011) | 3 lines

 Adding .dirstamp to svn:ignore for libdisasm.


------------------------------------------------------------------------
r847 | mark@chromium.org | 2011-10-06 14:03:17 -0400 (Thu, 06 Oct 2011) | 2
lines

10.4 SDK fix

------------------------------------------------------------------------
r848 | qsr@chromium.org | 2011-10-07 11:57:23 -0400 (Fri, 07 Oct 2011) | 4 lines

Allow minidump generator to generate ARM minidumps (for iOS on a device).

Review URL: http://breakpad.appspot.com/307002

------------------------------------------------------------------------
r849 | mark@chromium.org | 2011-10-07 18:05:05 -0400 (Fri, 07 Oct 2011) | 2
lines

Update linux-syscall-support (lss) to r7

------------------------------------------------------------------------
r850 | mark@chromium.org | 2011-10-07 18:08:14 -0400 (Fri, 07 Oct 2011) | 2
lines

Move svn:externals definitions closer to their points of use.

------------------------------------------------------------------------
r851 | qsr@chromium.org | 2011-10-10 06:29:22 -0400 (Mon, 10 Oct 2011) | 2 lines

 Do not commit user preferences for xcodeproj.

------------------------------------------------------------------------
r852 | qsr@chromium.org | 2011-10-10 10:02:29 -0400 (Mon, 10 Oct 2011) | 6 lines

 Extracting the config file class from the Inspector to be able to reuse it.

 This will be needed for iOS implementation, where the Inspector won't be
used, but where a config file will still be needed, because the uploads
won't happen just after the crash, but on a next run.
Review URL: http://breakpad.appspot.com/309001
------------------------------------------------------------------------
r853 | qsr@chromium.org | 2011-10-10 10:40:26 -0400 (Mon, 10 Oct 2011) | 5 lines

 Extract the uploader process from crash_report_sender

 The aim is to separate the process itself from the view, to be able to
reuse the process on the iOS platform.
Review URL: http://breakpad.appspot.com/309002
------------------------------------------------------------------------
r854 | qsr@chromium.org | 2011-10-10 10:43:03 -0400 (Mon, 10 Oct 2011) | 4 lines

 Use right header.

 Code was pulling Cocoa dependency, when Foundation is enough.
Review URL: http://breakpad.appspot.com/310001
------------------------------------------------------------------------
r855 | qsr@chromium.org | 2011-10-11 10:17:02 -0400 (Tue, 11 Oct 2011) | 7 lines

 Handle ios dump.

 This change add a flag for ios minidumps and allow handler to recognize it.

 It doesn't recognize arm specific exceptions that will be logged as unknown
type.
Review URL: http://breakpad.appspot.com/311002
------------------------------------------------------------------------
r856 | qsr@chromium.org | 2011-10-11 10:40:57 -0400 (Tue, 11 Oct 2011) | 4 lines

 Extract constants from Breakpad.h.

 This is done to allow ios implementation to use the same constants.
Review URL: http://breakpad.appspot.com/311001
------------------------------------------------------------------------
r857 | mark@chromium.org | 2011-10-11 12:47:47 -0400 (Tue, 11 Oct 2011) | 12
lines

#include BreakpadDefines.h as "BreakpadDefines.h" and not
<Breakpad/BreakpadDefines.h>.

During the build of Breakpad itself (especially in Chromium), there is no
Breakpad.framework/Headers in which to locate BreakpadDefines.h, so the
framework-style #include of <Breakpad/BreakpadDefines.h> is not able to find
anything to #include. Using the "BreakpadDefines.h" form should always locate
this file next to Breakpad.h whether it's in the framework or in the source
tree.

This fixes a Chromium build regression caused by Breakpad r856.
Review URL: http://breakpad.appspot.com/313001
------------------------------------------------------------------------
r858 | qsr@chromium.org | 2011-10-11 12:55:19 -0400 (Tue, 11 Oct 2011) | 4 lines

 Adding missing method.

 parameters method was missing on Uploader.
Review URL: http://breakpad.appspot.com/312001
------------------------------------------------------------------------
r859 | mark@chromium.org | 2011-10-11 13:37:32 -0400 (Tue, 11 Oct 2011) | 9
lines

Remove duplicate definition of GTMLoggerDebug.

The actual defintion comes from common/mac/GTMLogger.h, #imported above.

This removes a compilation warning that showed up in r853:

uploader.m:52:9: warning: 'GTMLoggerDebug' macro redefined
GTMLogger.h:339:9: note: previous definition is here
Review URL: http://breakpad.appspot.com/310002
------------------------------------------------------------------------
r860 | mark@chromium.org | 2011-10-11 13:38:01 -0400 (Tue, 11 Oct 2011) | 13
lines

Fix harmless printf abuse in symupload.

symupload printed -[NSData length], an NSUInteger, using %lu. %lu is proper
to print a "long" as unsigned, but NSUInteger is a typedef for "unsigned int"
when building for 32-bit. This would not have caused any problems, because in
the 32-bit model, both int and long are 32 bits wide. In the 64-bit model,
long is 64 bits wide, but NSUInteger is defiend as "unsigned long", so there
wouldn't have even been a warning in that case.

This addresses the following warning:

symupload.m:137:30:{137:28-137:31}{137:46-137:59}: warning: conversion specifies
type 'unsigned long' but the argument has type 'NSUInteger' (aka 'unsigned int')
[-Wformat]
Review URL: http://breakpad.appspot.com/313002
------------------------------------------------------------------------
r861 | mark@chromium.org | 2011-10-11 13:38:35 -0400 (Tue, 11 Oct 2011) | 14
lines

Fix harmless warning in dwarf_cfi_to_module.cc.

This function already establishes that (signed) i must be positive by the time
it assigns it to (unsigned) reg. Because reg is unsigned, it is impossible for
it to be negative. Because i was already checked for positivity, this check
can be removed entirely. It was not a miswritten check that intended to check
i instead of reg, because i is already checked.

This addresses the following warning:

dwarf_cfi_to_module.cc:135:9: warning: comparison of 0 <= unsigned expression is
always true [-Wtautological-compare]

Committed r859
Review URL: http://breakpad.appspot.com/310003
------------------------------------------------------------------------
r862 | mark@chromium.org | 2011-10-11 13:59:03 -0400 (Tue, 11 Oct 2011) | 9
lines

Remove "using namespace std" from dwarf2reader.h. Using-directives are
forbidden by the style guide, and are bad practice in headers even under
style rules that tolerate this construct.

This fixes warnings such as:

In file included from dwarf2reader.cc:34:
dwarf2reader.h:53:17: warning: using namespace directive in global context in
header [-Wheader-hygiene]
Review URL: http://breakpad.appspot.com/312002
------------------------------------------------------------------------

[Mark Mentovai, 2011-10-11 18:17:59]

Also r863:

------------------------------------------------------------------------
r863 | mark@chromium.org | 2011-10-11 14:15:06 -0400 (Tue, 11 Oct 2011) | 7
lines

Use fixed revisions for svn:externals:

src/third_party/glog at r97
src/third_party/protobuf/protobuf at r407

Remove the bogus externals (not svn:externals) property from src.

------------------------------------------------------------------------

[Lei Zhang, 2011-10-11 18:36:56]

lgtm