Issue 8233011: Refactor and fix polymorphic KeyedStoreIC creation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8233011: Refactor and fix polymorphic KeyedStoreIC creation (Closed)

Created:
9 years, 2 months ago by Jakob Kummerow

Modified:
9 years, 2 months ago

Reviewers:
danno

CC:
v8-dev, Yang

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Refactor and fix polymorphic KeyedStoreIC creation Committed: http://code.google.com/p/v8/source/detail?r=9584

Patch Set 2 : fix nits #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+220 lines, -333 lines)			Patch
M	src/arm/stub-cache-arm.cc	View	1	3 chunks	+16 lines, -62 lines	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View	1	3 chunks	+19 lines, -68 lines	0 comments	Download
M	src/ic.h	View		3 chunks	+7 lines, -19 lines	0 comments	Download
M	src/ic.cc	View	1	5 chunks	+98 lines, -57 lines	0 comments	Download
M	src/mips/stub-cache-mips.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects.h	View		2 chunks	+19 lines, -0 lines	0 comments	Download
M	src/objects.cc	View		6 chunks	+36 lines, -56 lines	0 comments	Download
M	src/stub-cache.h	View	1	2 chunks	+4 lines, -8 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View	1	3 chunks	+20 lines, -62 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

PTAL. The changes in objects.{h,cc} are purely refactoring changes with no intended change in functionality.

9 years, 2 months ago (2011-10-11 14:53:08 UTC) #1

danno

lgtm with nits http://codereview.chromium.org/8233011/diff/1/src/ic.cc File src/ic.cc (right): http://codereview.chromium.org/8233011/diff/1/src/ic.cc#newcode1101 src/ic.cc:1101: MaybeObject* maybe_code = compiler.CompileLoadMegamorphic(receiver_maps, Rename this ...

9 years, 2 months ago (2011-10-11 15:16:29 UTC) #2