Check for compile-time constants in DartCompiler

compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java

Index: compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java
diff --git a/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java b/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java
index 734e27738812240a20a18a1bb45c2d2edd120166..a1dc5e373f9ac8a6817f1dea1e49c20270dcb1d1 100644
--- a/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java
+++ b/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java
@@ -56,6 +56,7 @@ public class TypeAnalyzerTest extends TypeTestCase {
   private Resolver resolver = new Resolver(context, getMockScope("<test toplevel>"), typeProvider);
   private final Types types = Types.getInstance(typeProvider);
   private HashSet<ClassElement> diagnosedAbstractClasses = new HashSet<ClassElement>();
+  private String lastSource;
 
   @Override
   protected void tearDown() {
@@ -1216,12 +1217,12 @@ public class TypeAnalyzerTest extends TypeTestCase {
     Map<String, ClassElement> classes = loadSource(
         "class GoodField {",
         "  static final int i = 1;",
-        "}",
-        "class BadField {",
-        "  static final int i = '';",
         "}");
     analyzeClass(classes.get("GoodField"), 0);
-    analyzeClass(classes.get("BadField"), 1);
+
+    // Note, the TypeAnalyzer doesn't get a chance
+    // to get its hands on bad initializers anymore
+    // due to type checking in CompileTimeConstVisitor.
   }
 
   public void testGetAllSupertypes()
@@ -1382,6 +1383,7 @@ public class TypeAnalyzerTest extends TypeTestCase {
   }
 
   private Map<String, ClassElement> loadSource(String source) {
+    lastSource = source;
     Map<String, ClassElement> classes = new LinkedHashMap<String, ClassElement>();
     DartUnit unit = parseUnit(source);
     TopLevelElementBuilder elementBuilder = new TopLevelElementBuilder();