Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: compiler/java/com/google/dart/compiler/ast/DartExpression.java

Issue 8231031: Check for compile-time constants in DartCompiler (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Feedback from floitsch Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiler/java/com/google/dart/compiler/ast/DartExpression.java
diff --git a/compiler/java/com/google/dart/compiler/ast/DartExpression.java b/compiler/java/com/google/dart/compiler/ast/DartExpression.java
index 9b0bb15a81cf9144ed77f6e9c1bb0e536950dacd..5a784ebb8bc702e57da52478b862b0b478827607 100644
--- a/compiler/java/com/google/dart/compiler/ast/DartExpression.java
+++ b/compiler/java/com/google/dart/compiler/ast/DartExpression.java
@@ -4,10 +4,13 @@
package com.google.dart.compiler.ast;
+import com.google.dart.compiler.type.Type;
+
/**
* Abstract base class for Dart expressions.
*/
public abstract class DartExpression extends DartNode {
+ Type type;
mmendez 2011/11/16 21:03:10 Nit: Should this be private?
zundel 2011/11/16 21:38:24 Removed - see http://codereview.chromium.org/85230
public boolean isAssignable() {
// By default you cannot assign to expressions.
@@ -18,4 +21,14 @@ public abstract class DartExpression extends DartNode {
public DartExpression getNormalizedNode() {
return (DartExpression) super.getNormalizedNode();
}
+
+ @Override
mmendez 2011/11/16 21:03:10 Nit: Since you added [set|get]Type here you might
zundel 2011/11/16 21:38:24 Removed - see http://codereview.chromium.org/85230
+ public void setType(Type type) {
+ this.type = type;
+ }
+
+ @Override
+ public Type getType() {
+ return type;
+ }
}

Powered by Google App Engine
This is Rietveld 408576698