Check for compile-time constants in DartCompiler

compiler/javatests/com/google/dart/compiler/end2end/inc/myother1.dart

Index: compiler/javatests/com/google/dart/compiler/end2end/inc/myother1.dart
diff --git a/compiler/javatests/com/google/dart/compiler/end2end/inc/myother1.dart b/compiler/javatests/com/google/dart/compiler/end2end/inc/myother1.dart
index 98c9f1b688f54508181508660d8181d55f19e8dd..e346e0f2437cf532b5802f0d0c4775706f49130f 100644
--- a/compiler/javatests/com/google/dart/compiler/end2end/inc/myother1.dart
+++ b/compiler/javatests/com/google/dart/compiler/end2end/inc/myother1.dart
@@ -2,10 +2,18 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+
 class Other1 {

[ngeoffray, 2011/10/14 09:26:56]

ditto.

[zundel, 2011/10/14 10:04:21]

I updated the comment, the old code violates the language.  Florian and I
discusses this initiailization when I was working on default values for function
parameters.

[ngeoffray, 2011/10/14 10:33:42]

Oh, OK. So the final Function FN = ... was accidental. Nevermind thenm thanks
for fixing it!

-  // The existence of this final triggers b/5078969.
-  static final Function FN = () { return 42; };
 
-  Other1() { }
+  // Static variables must be initialized with compile time constants.
+
+  static Function FN;
+
+  Other1() {
+
+    if (FN == null) {
+      FN = () { return 42; };
+    }
+  }
   void newMethod() { }
 }