Check for compile-time constants in DartCompiler

compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 package com.google.dart.compiler.resolver;
 
 import com.google.common.annotations.VisibleForTesting;
 import com.google.dart.compiler.DartCompilationError;
 import com.google.dart.compiler.DartCompilerContext;
 import com.google.dart.compiler.DartCompilerErrorCode;
 import com.google.dart.compiler.DartCompilerListener;
 import com.google.dart.compiler.ErrorCode;
 import com.google.dart.compiler.ast.DartClass;
 import com.google.dart.compiler.ast.DartField;
 import com.google.dart.compiler.ast.DartFieldDefinition;
 import com.google.dart.compiler.ast.DartFunctionTypeAlias;
 import com.google.dart.compiler.ast.DartMethodDefinition;
 import com.google.dart.compiler.ast.DartNode;
 import com.google.dart.compiler.ast.DartNodeTraverser;
 import com.google.dart.compiler.ast.DartTypeParameter;
 import com.google.dart.compiler.ast.DartUnit;
 import com.google.dart.compiler.ast.LibraryUnit;
+import com.google.dart.compiler.ast.Modifiers;
 import com.google.dart.compiler.common.SourceInfo;
 import com.google.dart.compiler.type.Types;
 
 import java.util.List;
 
 /**
  * Builds all class elements and types of a library. Once all libraries
  * of an application have built their types, the library scope per
  * library can be computed.
  */
@@ skipping 110 matching lines @@
     }
 
     @Override
     public Void visitMethodDefinition(DartMethodDefinition node) {
       node.setSymbol(Elements.methodFromMethodNode(node, library));
       return null;
     }
 
     @Override
     public Void visitField(DartField node) {
-      node.setSymbol(Elements.fieldFromNode(node, library, node.getModifiers()));
+      Modifiers modifiers = node.getModifiers();
+      if (modifiers.isFinal()) {
+        // final toplevel fields are implicitly compile-time constants.

[ngeoffray, 2011/10/17 10:59:38]

Again, since they must all be compile-time constants, I think you can drop that.

+        modifiers = modifiers.makeConstant();
+      }
+      node.setSymbol(Elements.fieldFromNode(node, library, modifiers));
       return null;
     }
   }
 }